[Debian-med-packaging] Please upload NEW hhsuite

[Andreas Tille]

Hi Laszlo,

I had a look (hopefully no race condition with Steffen ;-)).

Some minor remarks - only the first one is relevant for sponsering
the package because most probably ftpmaster will stumble upon
missing license statement

  1. debian/copyright:
     Files: lib/ffindex/*
     Copyright: Andy Hauser <hauser at genzentrum.lmu.de>
     License: Create Commons license "Attribution-ShareAlike 3.0"

     Ftpmaster might insist on specifying this license explicitely
     because there is no copy at /usr/share/common-licenses.
     There are also some more nitpicking warnings given by lintian
     which are not that critical.  I recently learned that

       config-edit -application dpkg-copyright debian/copyright

     might be helpful.

  2. README.source:
     You are describing the patches you applied.  If you try
       lintian -i -I *.dsc
     you get a hint to prefer this straight inside the patches
     which makes sense because it is better visible for upstream

  3. debian/rules:
     - You tend to use .PHONY statements which is IMHO just not
       necessary (or do you have any evidence that something does
       not work as expected without these?)

  4. lintian -i -I:
     * I: hhsuite: spelling-error-in-binary usr/bin/hhfilter exceded exceeded
       ... you seem to have good contact to upstream
     * I: hhsuite source: binary-control-field-duplicates-source field "priority" in package hhsuite-dbg
       ... just drop this extra information
     * I: hhsuite source: duplicate-short-description hhsuite hhsuite-dbg
       ... add something like "(debug package)" or so and similarly
       for the libraries.

Thanks for your work on this and please handle at least item 1 while the
others would be simply nice to have.

     Andreas.

On Wed, Feb 22, 2012 at 12:37:46PM +0100, Laszlo Kajan wrote:
> Hello Steffen!
> 
> Please upload the Soeding group's hhsuite! Thank you!
> 
> @Andreas: thank you very much for making this available to all of us. I am going to follow your (frequent) updates of the upstream tarball. Are
> you interested in incorporating some of the patches I made to the upstream? You can have a look here:
> 
>  http://anonscm.debian.org/viewvc/debian-med/trunk/packages/hhsuite/trunk/debian/patches/Makefile?view=markup
> 
> Of special interest are the $(MAKE) -C modifications that allow parallel build of the package.
> 
> Best regards,
> 
> Laszlo
> 
> _______________________________________________
> Debian-med-packaging mailing list
> Debian-med-packaging at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/debian-med-packaging
> 

-- 
http://fam-tille.de