[Debian-med-packaging] Bug#657478: biomaj-watcher: doesn't use invoke-rc.d

[Andreas Beckmann]

Package: biomaj-watcher
Version: 1.2.0-3
Severity: serious
User: debian-qa at lists.debian.org
Usertags: piuparts

Hi,

during a test with piuparts I noticed your package starts processes
where it shouldnt. This is very probably due to not using invoke-rc.d as
mandated by policy 9.3.3.2. This is seriously disturbing! ;-)

See http://www.debian.org/doc/debian-policy/ch-opersys.html#s9.3.3
and /usr/share/doc/sysv-rc/README.invoke-rc.d.gz as well
as /usr/share/doc/sysv-rc/README.policy-rc.d.gz

>From the attached log (scroll to the bottom...):

  Selecting previously unselected package biomaj-watcher.
  (Reading database ... 13418 files and directories currently installed.)
  Unpacking biomaj-watcher (from .../biomaj-watcher_1.2.0-3_all.deb) ...
  Setting up biomaj-watcher (1.2.0-3) ...
  /var/lib/dpkg/info/biomaj-watcher.config: 18: [: =: unexpected operator
  Updating Context.xml...
  Configuration complete
  Starting Tomcat servlet engine: tomcat6.

This should not have happened - policy-rc.d would have prevented
starting tomcat.

Therefore processes are left around:

1m12.2s DEBUG: Starting command: ['lsof', '-w', '+D', '/tmp/piupartss/tmpdlJbX8']
1m12.5s DUMP: 
  COMMAND   PID       USER   FD   TYPE DEVICE SIZE/OFF     NODE NAME
  java    10661 messagebus  cwd    DIR   0,19      180 22705197 /tmp/piupartss/tmpdlJbX8/var/lib/tomcat6
  java    10661 messagebus  rtd    DIR   0,19      440 22646097 /tmp/piupartss/tmpdlJbX8
  java    10661 messagebus  txt    REG   0,19    36048 22697509 /tmp/piupartss/tmpdlJbX8/usr/lib/jvm/java-6-openjdk-amd64/jre/bin/java
  ...

Also note the error in the config script, use
    if [ "$RET" = "true" ]
         ^    ^
to fix this.


cheers,

Andreas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: biomaj-watcher_1.2.0-3.log.gz
Type: application/x-gzip
Size: 18284 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20120126/4b562a8e/attachment-0001.bin>