[Debian-med-packaging] Bug#667939: last-align: Hardening flags missing

[Martin Frith]

Many thanks Andreas.

As a small clarification, the CXXFLAGS setting in "makefile"
(intentionally) overrides the setting in "src/makefile".  The idea is for
the user/installer to compile without warnings (by using the toplevel
makefile), while the developer can compile with warnings (by using the src
makefile).  I'm not sure if there's a more standard way of doing that.

On Mon, May 7, 2012 at 10:03 PM, Andreas Tille <andreas at an3as.eu> wrote:

> Hi Martin,
>
> On Mon, May 07, 2012 at 05:50:26PM +0900, Martin Frith wrote:
> > I used part of your patch in LASTv199.  (I didn't include the "+="
> changes,
> > because I think the purpose of those flag variables is to let you
> override
> > them if you want to.  You might consider including "-O3" in your
> override.)
>
> We can deal with your decision but usually we do not really want to
> override but just add additional flags (like for hardening).  The thing is
> that you as the author have choosen a set of flags on purpose.  If we
> blindly override these we might not gain the same optimisation / whatever.
> For the moment I worked around this that I used a 1:1 copy of your flags
> in src/makefile and added the hardening flags.  The problem is if you might
> change some options in future versions I might miss this change.  So for
> now
> it is fine but the "+=" solution seems to be the better one.
>
> > By the way, in your "rules" file, I think "clean" is no longer needed
> (now
> > in the upstream makefile), nor is "--directory src" (there is now a
> > top-level makefile).
>
> Thanks for the hints and the extra comfort of the top-level makefile
> which is used now.
>
> > Please let me know if I misunderstood something.
>
> No real misunderstanding - as I said we can live with this for now.
>
> Thanks for your support
>
>      Andreas.
>
> --
> http://fam-tille.de
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/debian-med-packaging/attachments/20120508/d79b90da/attachment.html>