[Debian-med-packaging] spades_3.6.2+dfsg-1_amd64.changes REJECTED

[Sascha Steinbiss]

Hi Andreas,

welcome back to Germany! :)

> On Mon, Feb 08, 2016 at 11:38:30AM +0000, Sascha Steinbiss wrote:
>> Just to keep you updated, I have worked my way through:
>>
>>   /vagrant/spades/src $ git grep opyrig | grep -v etersbur | cut -f1 -d:
>>
>> as well and added missing license info to d/copyright. Pushed just now.
> 
> Great!

I hope I didn't miss anything. It's a lot of quite diverse stuff indeed,
with and without modification.

>> Something that caught my eye is that SPades includes a copy of the RSA
>> MD5 implementation, which contains an advertising clause which is
>> probably not DFSG compliant. It might be possible to patch the code
>> similar to [1] (replace with Colin Plumb's free implementation).
>> Interesting that other packages retain that code (e.g. [2]).
> 
> I currently can't research the details behind (which I'm not aware of).
> Any chance to use Debian packaged code rather than any code copy?

Unsure. Other packages also just bundle a copy of this small-ish file
and it looks like the SPAdes code has extended it to be more C++-like.
I will take a closer look later when I am off work.

>> Any comments? If we want to patch can look into this later.
> 
> Any opinion about the wrapper issue?

I don't feel so strongly but tend to agree with Joey Hess's stance [1]
and would consider SPAdes to be an interface here. So I'd propose to
move all upstream executables to /usr/lib/spades/bin and symlink both
/usr/bin/{dip,tru}?spades and /usr/bin/{dip,tru}?spades.py to their
counterparts in /usr/lib/spades/bin. From what I gather from upstream
the original 'spades' binary is not meant to be run directly anyway.
This could mean having to patch the python wrapper to force the use of
the /usr/lib version of the original 'spades' binary.

Cheers
Sascha

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=190753#128


-- 
 The Wellcome Trust Sanger Institute is operated by Genome Research 
 Limited, a charity registered in England with number 1021457 and a 
 company registered in England with number 2742969, whose registered 
 office is 215 Euston Road, London, NW1 2BE.