[Debian-olpc-devel] python-xklavier -- Python bindings for libxklavier

[Jonas Smedegaard]

On Fri, Apr 16, 2010 at 08:52:40PM +0200, Jonas Smedegaard wrote:
>On Fri, Apr 16, 2010 at 08:40:26PM +0200, Jonas Smedegaard wrote:
>>On Fri, Apr 16, 2010 at 12:47:22PM -0400, Luke Faraone wrote:
>
>>>Anything else that needs fixing?
>>
>>The binary package has an empty Conflicts: line.
>>
>>Apart from all this nitpicking: No, I really like your packaging!
>
>Oh, actually there is one other thing: I recommend adding 
>debian/gbp.conf similar to e.g. sugar packages (without bzip2 hint if 
>this project releases tarballs only as gzip), and import sources 
>including pristine-tar option.

...and there might be another (noticed but didn't double-check): 
build-dependency on libxklavier-dev should probably be tightened to 
match newest upstream reuirement.

It is always a good idea (sorry if obvious to you and you do it already) 
to skim all upstream code changes after each new upstream release, like 
this right after git-import-orig:

     git log -p upstream^..upstream


  - Jonas

-- 
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-olpc-devel/attachments/20100417/c84c0d55/attachment.pgp>