[Debian-olpc-devel] Fwd'd review of sugar-moon-activity [was: Fwd: ITP: sugar-moon-activity -- Moon is a simple Lunar phase activity for Sugar, including upcoming Lunar eclipse information and effects.]

[Luke Faraone]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Such mails would probably be better suited for the debian-olpc mailing
list. Please send them there in the future.

- -lwf

- -------- Original Message --------
Subject: 	Fwd: ITP: sugar-moon-activity -- Moon is a simple Lunar phase
activity for Sugar, including upcoming Lunar eclipse information and
effects.
Date: 	Sat, 7 Aug 2010 19:02:18 +0530
From: 	Manusheel Gupta <manu at laptop.org>
To: 	Ubuntu SugarTeam <ubuntu-sugarteam at lists.ubuntu.com>



Copying ubuntu-sugar list serv for archiving the reviews on
sugar-moon-activity.

Regards,

Manu

- ---------- Forwarded message ----------
From: *Ankur Khurana* <ankur at seeta.in <mailto:ankur at seeta.in>>
Date: Sat, Aug 7, 2010 at 9:03 AM
Subject: Re: ITP: sugar-moon-activity -- Moon is a simple Lunar phase
activity for Sugar, including upcoming Lunar eclipse information and
effects.
To: Ishan Bansal <ishan at seeta.in <mailto:ishan at seeta.in>>
Cc: Neeraj Gupta <neeraj at seeta.in <mailto:neeraj at seeta.in>>, Manusheel
Gupta <manu at seeta.in <mailto:manu at seeta.in>>,


Review of activity based on commit:on initial commit:
1.There is no pristine branch.When pushing use --all after git push and
before the address to be pushed.I have updated the google doc, please
take a look at it as well.

2.dont use © in copyright file. and give ',' after the year and before
the copyright holder.check copyright_hints to check any other copyright
holder.

3.order of files in copyright is:

 1) default - i.e. "*" or the Files: lines left out completely
 2) subdir match using wildcard
 3) file match
 4) explicit path match
 5) ./debian/* match
 6) debian subdir match - e.g. ./debian/patches/*
please try to follow this order.

4.Always, Always run clean rule before you add anything to git or upload
it.It removes lot of uneccesaary files.

5.In Control file, always wrap your description at 72 characters per
liune.if use next line to complete the description.You might like to
change sugar moon activity to Sugar Moon Activity in description in
control file.

6 In README.sources file, you might like to remove from line 19 to 74 as
it does not concerns our packages as of now.

7.Well your format of giving url in watch file is wrong.
It should be like this :
http://download.sugarlabs.org/sources/honey/Moon/Moon-(.*)\.tar\.bz2
<http://download.sugarlabs.org/sources/honey/Moon/Moon-(.*)%5C.tar%5C.bz2>

I think, make these changes first, will have a other look aftere sometime.


On Sat, Aug 7, 2010 at 2:10 AM, Ishan Bansal <ishan at seeta.in
<mailto:ishan at seeta.in>> wrote:

    plz review the package-: sugar-moon-activity

Regards,
Ankur


- -- 
Luke Faraone
http://luke.faraone.cc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAkxdwBYACgkQtrC51grHAgYv/wCgkrQYCByxds6nKdz/G2FUmJmy
2LcAn1DmZg/7IIDIV2tEtmUtJWvn3zGy
=zhIF
-----END PGP SIGNATURE-----