[Debian-olpc-devel] include both specifics and general info in reviews

[Jonas Smedegaard]

Hi all,


>From: *Ankur Khurana* <ankur at seeta.in <mailto:ankur at seeta.in>>

>Review of activity based on commit:on initial commit:
>1.There is no pristine branch.When pushing use --all after git push and 
>before the address to be pushed.I have updated the google doc, please 
>take a look at it as well.
[...and some more comments, snippet here]

The points reaised in the review are all good.

I do suggest, however, to try include more "source" too.

I mean, in addition to describing what specifically needs changed, also 
mention why, more generally. Either elaborate on reasoning in your own 
words or refer to some URL for more info.

That way the reviews encourage learning in the art of packaging rather 
than just adding to a big pile of seemingly independent pieces to 
memorize.


My reviews tend include too little specific details. Others, including 
the above quoted, in my opinion includes too little background info.  
Ideally they should contain both, I believe: specific details *and* 
(references to) background info. :-)


  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-olpc-devel/attachments/20100809/e5bbb04e/attachment.pgp>