[Debian-olpc-devel] include both specifics and general info in reviews
ankur at seeta.in
Wed Aug 11 16:40:30 UTC 2010
HI jonas and others :) ,
I agree with you and will try to mention the the sources as well. Well in
this case, i have merely mentioned the pointers this time around but i will
make sure in future that i try to include what you have mentioned :) .
Thanks for pointing that out.
On Tue, Aug 10, 2010 at 4:39 AM, Jonas Smedegaard <dr at jones.dk> wrote:
> Hi all,
> From: *Ankur Khurana* <ankur at seeta.in <mailto:ankur at seeta.in>>
> Review of activity based on commit:on initial commit:
>> 1.There is no pristine branch.When pushing use --all after git push and
>> before the address to be pushed.I have updated the google doc, please take a
>> look at it as well.
> [...and some more comments, snippet here]
> The points reaised in the review are all good.
> I do suggest, however, to try include more "source" too.
> I mean, in addition to describing what specifically needs changed, also
> mention why, more generally. Either elaborate on reasoning in your own words
> or refer to some URL for more info.
> That way the reviews encourage learning in the art of packaging rather than
> just adding to a big pile of seemingly independent pieces to memorize.
> My reviews tend include too little specific details. Others, including the
> above quoted, in my opinion includes too little background info. Ideally
> they should contain both, I believe: specific details *and* (references to)
> background info. :-)
> - Jonas
> * Jonas Smedegaard - idealist & Internet-arkitekt
> * Tlf.: +45 40843136 Website: http://dr.jones.dk/
> [x] quote me freely [ ] ask before reusing [ ] keep private
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> -----END PGP SIGNATURE-----
> Debian-olpc-devel mailing list
> Debian-olpc-devel at lists.alioth.debian.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Debian-olpc-devel