[Debian-olpc-devel] include both specifics and general info in reviews

[Ankur Khurana]

HI jonas and others :) ,

I agree with you and will try to mention the the sources as well. Well in
this case, i have merely mentioned the pointers this time around but i will
make sure in future that i try to include what you have mentioned  :) .
Thanks for pointing that out.


Regards,
Ankur

On Tue, Aug 10, 2010 at 4:39 AM, Jonas Smedegaard <dr at jones.dk> wrote:

> Hi all,
>
>
>  From: *Ankur Khurana* <ankur at seeta.in <mailto:ankur at seeta.in>>
>>
>
>  Review of activity based on commit:on initial commit:
>> 1.There is no pristine branch.When pushing use --all after git push and
>> before the address to be pushed.I have updated the google doc, please take a
>> look at it as well.
>>
> [...and some more comments, snippet here]
>
> The points reaised in the review are all good.
>
> I do suggest, however, to try include more "source" too.
>
> I mean, in addition to describing what specifically needs changed, also
> mention why, more generally. Either elaborate on reasoning in your own words
> or refer to some URL for more info.
>
> That way the reviews encourage learning in the art of packaging rather than
> just adding to a big pile of seemingly independent pieces to memorize.
>
>
> My reviews tend include too little specific details. Others, including the
> above quoted, in my opinion includes too little background info.  Ideally
> they should contain both, I believe: specific details *and* (references to)
> background info. :-)
>
>
>  - Jonas
>
> --
>  * Jonas Smedegaard - idealist & Internet-arkitekt
>  * Tlf.: +45 40843136  Website: http://dr.jones.dk/
>
>  [x] quote me freely  [ ] ask before reusing  [ ] keep private
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
>
> iQIcBAEBCgAGBQJMYIqaAAoJECx8MUbBoAEhNb4P/3/gjO4lj9vL22Sl0NmUHoWe
> CPk3ebdIaFn5INarpZhj5YGJYG2hVbAsxveznhieLoTVFSypyPjBXNjn2BMEzQOV
> GUsTnFaxpZVe/8E92Ar6Vbqw+ZacFX7HDKMhkublzQaNvalbd/XaQNgJi8EiuU22
> x8Au3QZSXTa/tJR498Mwb2yYRFl09lsa2vp70bJvgn03oFERMqSFE6L2Ewx26cjl
> KXUb/R0HLnrGYB2ClqEDVfBBCRwCGFO+XSfTKnxEHVpNKamPZHE0kfxeJQLHXf5d
> wwOex3jGrpC2Ku+ZTOwpmD1tcXFwbrkOK6/cbhB/4rdI/8xbT2oKcn1z7F5uOUre
> IBBQzcsb2ckMO7PpLogzTAHnx1sp8EcZcxdw8zxtOOOUABWTEBZUIW29cWJJXOtV
> IIoBEyxysUd5EdWr03ZKivg4Ja+2D50Kd/fVgyPehZxhVT13pLpnCb0nX9+P9mpa
> PYNzKD2bnGefF8JgfDCDt5yK46hKZyAkDBQuWdzV9cI2ziukCmmGPEmdFTqrGj6D
> 4KoXE5lVinQ/SwesQyOLTp8425RhTVl6Enpei73TllYKZr6Rykvie9sVN7ERm4g9
> +8qgRYlCnHHMUTM2Cc+JD8RlL/ITrk3Qpw3D/YUeZ1Ag3+lJeur5v6kluDQy0zYR
> bylIpbIaYGseOjSgz5as
> =cSrV
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Debian-olpc-devel mailing list
> Debian-olpc-devel at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/debian-olpc-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/debian-olpc-devel/attachments/20100811/2fdff874/attachment.htm>