[Debian-olpc-devel] Review of sugar-jigsawpuzzle-activity

[Jonas Smedegaard]

Hi Ankur,

On Thu, Jul 22, 2010 at 12:00:19PM -0400, Luke Faraone wrote:
>  * debian/copyright:
>    - Per DEP5[1], use the approved
>shortnamhttp://dep.debian.net/deps/dep5/#index3h4e for the LGPL. You
>want "LGPL-2.1+".
>    - Please include the abbreviated license text for LGPL as you did
>with the GPL.
>
>  * debian/rules:
>    - Remove MANIFEST in your clean:: rule.


On Fri, Jul 23, 2010 at 12:55:16AM +0530, Ankur Khurana wrote:
>I have added a rule in clean rule to remove MANIFEST .

Good.


>But i am not clear no the abbreviated text.That refers to the paragraph 
>at the end? .Anything else you would like to get rectified in package?

In the file debian/copyright you properly include some File sections 
with a License hint.  And you properly a License section with the 
details of the GPL-2+ hint.

One File section, however, use the License hint "LGPL v2.1+".

One (minor) issue it that this hint should preferrably use the standard 
name "LGPL-2.1+".

Another more important issue is that this hint must have a corresponding 
License section containing the actual licensing text (similar to the 
GPL-2+ one).


Hope this helps,

  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/debian-olpc-devel/attachments/20100722/d1740864/attachment-0001.pgp>