[Debian-olpc-devel] Bug#584717: sugar-artwork-0.88: 1002_skip_none-arow_only_if_supported.patch causes activities to break

[Sascha Silbe]

Package: sugar-artwork-0.88
Version: 0.88.0-1
Severity: normal


1002_skip_none-arow_only_if_supported.patch causes (at least) the activities View Slides and Library to abort on invocation with the following error:

ERROR:sugar-drawing.c:390:sugar_draw_rounded_arrow: code should not be reached


IRC transcript:

00:01 < benzea> silbe, alsroot: weird
00:02 < benzea> alsroot: it never should happen
00:03 < benzea> alsroot: unless an invalid arrow type is passed to the engine (I first thought it might be I 
                forgot about arrow_none, but the check for that is there)
00:03 < benzea> (as treeviews draw ARROW_TYPE_NONE in the header if no sort arrow is displayed for a certain 
                row)
00:07 < benzea> silbe: I wonder how the assert can be triggered, easy fix is to just remove it ...
00:07 < benzea> the engine will keep running fine
00:13 < benzea> silbe: wait, what gtk version?
00:13 < benzea> #ifdef GTK_ARROW_NONE
00:13 < benzea>     if (arrow_type == GTK_ARROW_NONE)
00:13 < benzea>         return;
00:13 < benzea> #endif
00:13 < silbe> benzea: 2.20.1-1
00:13 < benzea> debian added a small easter egg ...
00:14 < silbe> what did they do?
00:15 < benzea> oh yes
00:15 < benzea> well, GTK_ARROW_NONE is a enum type
00:15 < benzea> they added the #ifdef, to be able to compile against older versions that gtk+ 2.10
00:17 < silbe> benzea: ok, I see the patch. :-/
00:19 < silbe> benzea: AFAIR they needed to backport GTK (for running Sugar on lenny) anyway because of other 
               dependencies (gio IIRC), so just dropping that patch is probably enough.
00:19 < benzea> so, best thing would be to do:
00:20 < benzea> #if GTK_CHECK_VERSION(2,10,0)
00:20 < benzea>   use 4 hardcoded
00:20 < benzea> #else
00:20 < benzea>   normal code
00:20 < benzea> #endif
00:20 < benzea> I guess
00:26 < benzea> doesn't sugar depend on gtk+ 2.16 anyways?


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.31.6-xo1.5-2-00362-g6eb5eec (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages sugar-artwork-0.88 depends on:
ii  libatk1.0-0             1.30.0-1         The ATK accessibility toolkit
ii  libc6                   2.10.2-9         Embedded GNU C Library: Shared lib
ii  libcairo2               1.8.10-4         The Cairo 2D vector graphics libra
ii  libfontconfig1          2.8.0-2.1        generic font configuration library
ii  libfreetype6            2.3.11-1         FreeType 2 font engine, shared lib
ii  libglib2.0-0            2.24.1-1         The GLib library of C routines
ii  libgtk2.0-0             2.20.1-1         The GTK+ graphical user interface 
ii  libpango1.0-0           1.28.0-1         Layout and rendering of internatio
ii  ttf-dejavu-core         2.30-2           Vera font family derivate with add
ii  zlib1g                  1:1.2.3.4.dfsg-3 compression library - runtime

Versions of packages sugar-artwork-0.88 recommends:
pn  sugar-0.88                    <none>     (no description available)
ii  ttf-dejavu-extra              2.30-2     Vera font family derivate with add

sugar-artwork-0.88 suggests no packages.

-- no debconf information