[Debian-olpc-devel] Review of sugar-speak-activity

[Luke Faraone]

Hi,

On 08/25/2010 11:32 PM, Luke Faraone wrote:
> I noticed that your package depends on some things it does not need, and
> may not depend on everything it needs for execution. Please recheck your
> package (as we should all be doing per Jonas' mail), grepping the source
> for applicable import statements.

After reviewing the source code, I noticed missing dependencies on the
following:
	python-numpy
	python-gettext
	python-hippocanvas ("import hippo")

With hippocanvas, it's partially my fault, since I advised you that if
your code didn't use the "hippocanvas" module you were okay, but instead
it turns out the module is shipped as "hippo" instead.

In addition, python-aiml and espeak are declared directly in
debian/control.(in). For consistency, please declare these deps instead
in debian/rules.

-- 
╒═════════════════════════════════════════════════════════════════╕
│Luke Faraone                          ╭Debian / Ubuntu Developer╮│
│http://luke.faraone.cc                ╰Sugar Labs, Systems Admin╯│
│PGP: 5189 2A7D 16D0 49BB 046B  DC77 9732 5DD8 F9FD D506          │
╘═════════════════════════════════════════════════════════════════╛