<div class="gmail_quote">On Tue, Nov 17, 2009 at 09:16, Jonas Smedegaard <span dir="ltr"><<a href="mailto:dr@jones.dk">dr@jones.dk</a>></span> wrote:<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
As workaround until possibly improved upstream, I suggest to avoid using the makefile directly and instead replicate the non-python parts of it in debian/rules. Â In other words, drop the <a href="http://makefile.mk" target="_blank">makefile.mk</a> cdbs snippet, and instead include <a href="http://makefile-vars.mk" target="_blank">makefile-vars.mk</a>, and attach e.g. $(DEB_MAKE_INVOKE) to the relevant core cdbs rules (tell me if you need help figuring those out) directly in debian/rules. <br>
</blockquote></blockquote></div></blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"></blockquote></blockquote></div>
Read /usr/share/cdbs/1/class/<a href="http://makefile-vars.mk" target="_blank">makefile-vars.mk</a> directly to see what it provides.<br></blockquote><div><br>I'm sorry, I read through it, but I'm not really sure how to apply this. <br>
<br>Are you suggesting that I duplicate the upstream makefiles in my debian/rules file? That seems like it might cause more problems than it's worth when upstream makes changes to their makefile, and might introduce subtle bugs. <br>
<br>If the current upstream-provided-makefile is insufficent, would it be more worthwhile to write a patch enabling Rainbow to use autotools?<br><br>In all honesty, I don't really understand the problem with using the current makefile with Python parts removed. <br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div class="im"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I tried building the package without "DEB_PYTHON_MODULE_PACKAGES =<br>
python-rainbow" in debian/rules and without "usr/lib/python*" in<br>
debian/python-rainbow.install. Either way, I ended up with a 2.5kb<br>
python-rainbow package which didn't include the python module.<br>
<br>
Proper way of doing things aside, I think the packages currently comply to Debian policy both in naming and behavior. Please let me know if this is not the case.<br>
</blockquote>
<br></div>
I fear that Debian _Python_ Policy is not followed accurately.<br></blockquote><div><br>Well, the package is currently lintian clean. I read through the Debian Python Policy, and didn't see anything that conflicted. <br>
 <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
No, I will not do the quite tiresome job of double-checking if your hand-coding is of as good quality as if you relied on well-tested structures.<br></blockquote><div><br>The only reason I had to hand-code was because the same structures you referenced didn't build a usable package when I attempted to use them. I more than welcome any changes you would suggest to get these defaults to work without odd hacks.<br>
<br></div></div>-- <br>Luke Faraone<br><a href="http://luke.faraone.cc">http://luke.faraone.cc</a><br>