<div class="gmail_quote">On Tue, Nov 17, 2009 at 13:58, Jonas Smedegaard <span dir="ltr"><<a href="mailto:dr@jones.dk">dr@jones.dk</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
That was the Python part. The makefile is still used for compiling the NSS library, and you need to ensure that Debian Policy §10.1 is respected. As an example, upstream use -O3 for a security-related library, and without being an expert in the area it is my understanding that optimizations stronger than -O2 has a higher risk of producing wrong code on unusual architectures like hppa.<br>
</blockquote><div><br>I'm not too familiar with it either. Michael: is there any particular reason for using -O3 on normal systems? <br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="im">
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
The only reason I had to hand-code was because the same structures you referenced didn't build a usable package when I attempted to use them. I more than welcome any changes you would suggest to get these defaults to work without odd hacks.<br>
</blockquote>
</div>
I believe that now after you've moved the Python code to a policy-compliant python-* package you can drop the DEB_PYTHON_MODULE_PACKAGES line from the rules file and still produce the exact same result.<br></blockquote>
<div><br>Removing the line caused debuild to die with:<br> dh_install: python-rainbow missing files (usr/lib/python*), aborting<br><br>Once I removed usr/lib/python* from python-rainbow.install, the packages built, but python-rainbow did not include the Python code. <br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I recommend dropping DH_VERBOSE (I consider that flag a debugging aid, not generally useful).<br></blockquote><div><br>Done. I set it to 0, so that I can easily toggle it later if needed. <br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I recommend moving DEB_PYTHON_SYSTEM up above all cdbs inclusions (not strictly needed but is simpler to look at).<br>I
recommend moving DEB_MAKE_INSTALL_TARGET below cdbs inclusions as there
is no benefit of declaring it early. Also I recommend to use recursive
expansion (drop the colon to use "=" instead of ":=" - the latter is
harmless in this particular instance but also unneeded).<br>
I suggest avoiding indented comments, as they are printed at build time whereas they (usually, and indeed here) are most relevant when _editing_ the rules file.<br></blockquote><div><br>Done.<br clear="all"></div></div><br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">You
still haven't fixed DEB_INSTALL_MANPAGES_myapp (there is no package
"myapp" so the variable is simply ignored). Also I recommend declaring
it above rules (but below cdbs inclusions) just for the nice structure
of it.<br></blockquote><br>Removed it entirely, the manpages were going in the right place anyway. <br> <br>Thanks,<br>Luke Faraone<br><a href="http://luke.faraone.cc">http://luke.faraone.cc</a><br>