Luke,<br><br>Thanks for reviewing the s-flipsticks-a.<br><br>I did the changes as you mentioned above. Also added my ITP Bug No. in the debian/changelog.<br><br>The problem that I was facing got fixed I guess.<br>I first pulled in your changes from repository then ran 'git commit -a'<br>
Then I was able to push my changes to the repository.<br><br>It would be great if you could check if my changes were pushed properly.<br><br>Thanks<br><br>Dipankar<br><br><div class="gmail_quote">On Thu, Jul 8, 2010 at 9:32 AM, Luke Faraone <span dir="ltr"><luke@faraone.cc></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA1<br>
<br>
Dipankar,<br>
<br>
Review based off commit 30cad08cfca630a26e2d05811289983cc92093ea.<br>
<br>
Overall, very good. I had a few comments and things that need fixing,<br>
which are mentioned below. Minor items I fixed myself, others you will<br>
need to fix manually and push up to <a href="http://git.debian.org" target="_blank">git.debian.org</a>.<br>
<br>
Always run the clean rule "fakeroot debian/rules clean" before commit to<br>
ensure that no autogenerated files (other than control, of course) are<br>
included. I ran the rule and it removed a number of files in debian/.<br>
<br>
There were some wording issues in the package description, which is<br>
fine. I updated the description and committed the changes.<br>
<br>
What follows are a list of items I found but did not correct. Please do<br>
so and commit each fix you implement separately.<br>
<br>
* debian/control:<br>
- description lines should be wrapped at 72 characters.<br>
- Add ${misc:Depends} to "Depends" of the binary package<br>
* debian/copyright:<br>
- should not include template text:<br>
> /* REMOVE THIS NOTICE WHEN YOU BUILD THE PACKAGE<br>
> Below should contain the Copyright and license of the files<br>
included in this package. See <a href="http://dep.debian.net/deps/dep5/" target="_blank">http://dep.debian.net/deps/dep5/</a> for more<br>
details. What follows is an example. CHANGE IT FOR THE SPECIFIC SOFTWARE<br>
YOU ARE BUILDING.<br>
> */<br>
- include © and the year for all copyright owners.<br>
- license and copyright of ./montage.py is not mentioned<br>
* debian/docs: include lesson plans in documentation¹<br>
* debian/rules:<br>
- remove redundant copy of COPYING in package after build²<br>
<br>
<br>
¹: debian/docs tells debhelper to install all the paths listed in the<br>
file into the packages' documentation folder,<br>
/usr/share/doc/PACKAGE_NAME/. See<br>
<<a href="http://www.debian.org/doc/maint-guide/ch-dother.en.html#s-docs" target="_blank">http://www.debian.org/doc/maint-guide/ch-dother.en.html#s-docs</a>> for<br>
more information on how to do this.<br>
<br>
²: You probably want to rm it in a "install/sugar-flipsticks-activity::"<br>
section. See<br>
<<a href="http://build-common.alioth.debian.org/cdbs-doc.html#id2542963" target="_blank">http://build-common.alioth.debian.org/cdbs-doc.html#id2542963</a>> for more<br>
info.<br>
<br>
Thanks,<br>
<br>
Luke Faraone<br>
<a href="http://luke.faraone.cc" target="_blank">http://luke.faraone.cc</a><br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v1.4.10 (GNU/Linux)<br>
<br>
iEYEARECAAYFAkw1TcwACgkQtrC51grHAgYT7wCgnh11kiWQXsumSq/QBJ8QyNBy<br>
atAAni0sMljPqLP7BuJKQJqHhTW26G9H<br>
=yOoW<br>
-----END PGP SIGNATURE-----<br>
</blockquote></div><br>