[SCM] an open source computer algebra system branch, cleanedupstream, updated. 6125e540ca6d66c307958938a9d53b245507c323

Bernhard R. Link brlink at debian.org
Tue Apr 24 15:55:01 UTC 2012


The following commit has been merged in the cleanedupstream branch:
commit faed0fed0d24b9f460f29af8993001b730cdd0ba
Author: Martin Lee <martinlee84 at web.de>
Date:   Fri Feb 17 12:52:23 2012 +0100

    chg/fix: removed check for squarefreeness of reduction mod p

diff --git a/factory/facBivar.cc b/factory/facBivar.cc
index b0f2598..8cc08c0 100644
--- a/factory/facBivar.cc
+++ b/factory/facBivar.cc
@@ -588,25 +588,11 @@ CFList biFactorize (const CanonicalForm& F, const Variable& v)
   {
     Off (SW_RATIONAL);
     int i= 0;
-    do
-    {
-      find_good_prime(F,i);
-      find_good_prime(Aeval,i);
-      find_good_prime(A,i);
-      setCharacteristic (cf_getSmallPrime(i));
-      if (gcd (Aeval.mapinto(), deriv (Aeval,x).mapinto()).inCoeffDomain())
-      {
-        setCharacteristic (0);
-        break;
-      }
-      else
-        i++;
-      if (i > cf_getNumSmallPrimes())
-      {
-        printf ("out of primes\n");
-        break;
-      }
-    } while (1);
+    find_good_prime(F,i);
+    find_good_prime(Aeval,i);
+    find_good_prime(A,i);
+    if (i >= cf_getNumSmallPrimes())
+      printf ("out of primes\n"); //TODO exit
 
     int p=cf_getSmallPrime(i);
     b = coeffBound( A, p );

-- 
an open source computer algebra system



More information about the debian-science-commits mailing list