[pyfr] 29/32: Fix a possible bug in metric basis regarding accuracy.

[Ghislain Vaillant]

This is an automated email from the git hooks/post-receive script.

ghisvail-guest pushed a commit to branch master
in repository pyfr.

commit 7ebfd361589ba475e5798e5469b682c68aa930ed
Author: aerojspark <jin-seok.park at imperial.ac.uk>
Date:   Tue Apr 19 14:20:44 2016 +0100

    Fix a possible bug in metric basis regarding accuracy.
---
 pyfr/shapes.py | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/pyfr/shapes.py b/pyfr/shapes.py
index 6befa2d..0c8013b 100644
--- a/pyfr/shapes.py
+++ b/pyfr/shapes.py
@@ -59,14 +59,7 @@ class BaseShape(object):
             # on the both adjacent cells.
             # Ref. 1 JCP 281, 28-54, Sec 4.2
             # Ref. 2 JSC 26(3), 301-327, Definition 1
-            if nsptord >= self.order + 1:
-                # Construct metric basis when q > p
-                self.mbasis = get_polybasis(
-                    self.name, self.order + 1, self.mpts
-                )
-            # Use sbasis when q <= p
-            else:
-                self.mbasis = self.sbasis
+            self.mbasis = get_polybasis(self.name, self.order + 1, self.mpts)
 
     @classmethod
     def nspts_from_order(cls, sptord):
@@ -317,11 +310,8 @@ class BaseShape(object):
 
     @lazyprop
     def mpts(self):
-        if self.nsptsord >= self.order + 1:
-            return self.std_ele(self.order)
-        else:
-            return self.spts
-
+        return self.std_ele(self.order)
+    
     @lazyprop
     def nmpts(self):
         return len(self.mpts)

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/debian-science/packages/pyfr.git