Sponsoring Imview

[Charles Plessy]

Le Mon, Aug 04, 2008 at 11:03:29PM +0200, Teemu Ikonen a écrit :
> Hi all,
> 
> There's a new version of Imview available at mentors.debian.net:
> http://mentors.debian.net/debian/pool/main/i/imview
> It fixes some bugs and changes the maintainer to this list.

Hello Teemu,

I had a look (debdiff) on your updated package. The changes look
straightforward, as they consist mostly in the application of a patch.
However, with time, the information of what consists of this patch and
what consists of other changes will get more and more difficult to
extract, as your git repository does not seem to use branches, nor the
source packages contains a copy of the unapplied patch.

anx159《imview》$ debdiff imview_1.1.9c-1.dsc imview_1.1.9c-2.dsc | lsdiff 
imview-1.1.9c/debian/changelog
imview-1.1.9c/debian/compat
imview-1.1.9c/debian/control
imview-1.1.9c/debian/imview.doc-base
imview-1.1.9c/imageIO.cxx
imview-1.1.9c/imlines.cxx
imview-1.1.9c/my_Image.cxx
imview-1.1.9c/imtranslate.cxx
imview-1.1.9c/transferFunction.cxx
imview-1.1.9c/transferHistoBox.cxx
imview-1.1.9c/transferRGBFunction.cxx
imview-1.1.9c/transferRGBHistoBox.cxx
imview-1.1.9c/io/readMagick.cxx
imview-1.1.9c/io/readjpeg.cxx
imview-1.1.9c/io/readpnm.cxx

anx159《tmp》$ zcat imview_1.1.9c-1.diff.gz | lsdiff
imview-1.1.9c/bivHist.cxx
imview-1.1.9c/configure.in
imview-1.1.9c/COPYRIGHT
imview-1.1.9c/doc/imview.1
imview-1.1.9c/imageViewer.cxx
imview-1.1.9c/imnmspc.hxx
imview-1.1.9c/imview.cxx
imview-1.1.9c/imview.hxx
imview-1.1.9c/Makefile.in
imview-1.1.9c/menubar.hxx
imview-1.1.9c/menucb.cxx
imview-1.1.9c/debian/README.Debian
imview-1.1.9c/debian/changelog
imview-1.1.9c/debian/compat
imview-1.1.9c/debian/control
imview-1.1.9c/debian/copyright
imview-1.1.9c/debian/docs
imview-1.1.9c/debian/imview.desktop
imview-1.1.9c/debian/imview.doc-base
imview-1.1.9c/debian/imview.links
imview-1.1.9c/debian/menu
imview-1.1.9c/debian/rules
imview-1.1.9c/debian/watch
imview-1.1.9c/imview.xpm

anx159《tmp》$ zcat imview_1.1.9c-2.diff.gz | lsdiff 
imview-1.1.9c/COPYRIGHT
imview-1.1.9c/Makefile.in
imview-1.1.9c/bivHist.cxx
imview-1.1.9c/configure.in
imview-1.1.9c/imageIO.cxx
imview-1.1.9c/imnmspc.hxx
imview-1.1.9c/imlines.cxx
imview-1.1.9c/imageViewer.cxx
imview-1.1.9c/my_Image.cxx
imview-1.1.9c/imview.cxx
imview-1.1.9c/imtranslate.cxx
imview-1.1.9c/imview.hxx
imview-1.1.9c/imview.xpm
imview-1.1.9c/menubar.hxx
imview-1.1.9c/menucb.cxx
imview-1.1.9c/transferFunction.cxx
imview-1.1.9c/transferHistoBox.cxx
imview-1.1.9c/transferRGBFunction.cxx
imview-1.1.9c/transferRGBHistoBox.cxx
imview-1.1.9c/debian/README.Debian
imview-1.1.9c/debian/changelog
imview-1.1.9c/debian/compat
imview-1.1.9c/debian/control
imview-1.1.9c/debian/copyright
imview-1.1.9c/debian/docs
imview-1.1.9c/debian/imview.desktop
imview-1.1.9c/debian/imview.doc-base
imview-1.1.9c/debian/imview.links
imview-1.1.9c/debian/menu
imview-1.1.9c/debian/rules
imview-1.1.9c/debian/watch
imview-1.1.9c/doc/imview.1
imview-1.1.9c/io/readMagick.cxx
imview-1.1.9c/io/readjpeg.cxx
imview-1.1.9c/io/readpnm.cxx

Although the handling of patches is in part a matter of taste, there seems to
be a consensus that using "upstream branches", "feature branches" and
"integration branches" are a good practice when using packaging styles centered
around the utilisation of git.

I would recommend to address this issue before updating the package.

(By the way, have you forwarded the patch upstream?)

Have a nice day,

-- 
Charles Plessy
Debian Med packaging team,
Tsurumi, Kanagawa, Japan