Bug#619935: Bugs #619935 & #612621 : most debian/* files rewritten + patches

[Adam C Powell IV]

Hello Pierre,

On Thu, 2011-03-31 at 16:12 +0200, Pierre Saramito wrote:
> Hi Adam and Johannes,
> 
> > From Adam:
> > This is a very strange error in its irreproducibility...
> 
> Please find a tarball containing a new version of debian files,
> together with git-status and git-diff files (some files are added,
> others are removed). This new version fix two major bugs:
> 
>  #619935 FTBFS on several arches due to lex issue
>  #612621 SCOTCH_dgraphInit: linking with both libScotch and libPTScotch is not allowed
> 
> For the second bug, I've run the two tests from Johannes and run more complex tests (the 
> scotch library together with both pastix and rheolef, distributed environment).

I'm glad to hear that you found and solved the source of the Scotch
errors!  Thanks for all of your work on this.

> Here is the changes (see debian/changelog) :
> 
>   * Separate compilations for static & shared libs (closes: #612621)
>     Note: removing -DSCOTCH_PTHREAD was not sufficient

This makes a lot of sense.  If they could use libtool, which does this
automatically, our life would be easier...

>   * Add flags to flex & bison & gcc -DSCOTCH_RENAME_PARSER (closes: #619935)
>   * All patches/* has been simplified & merged in one short file, for clarity

I'm generally not a fan of merging patches like this.  But in this case
with lots of overlapping patches and all the changes you have made, I
think it makes sense, so I'm okay to do it this way.  I'm going to
change the header a bit though, and maybe the patch file name.

> These patch has been successfully checked with pbuilder on two arch: i386 & amd64
> and on sid, wheezy & squeeze dists. Also checked on ubuntu natty dist.

Wow, thanks for being so thorough!

> Could you, please upload these files ?

Thank you Pierre.  I will look over them carefully and merge them into
the git repository, then upload.

Already I can see a few issues:
      * I noticed that you removed -I/usr/include/lam from the CCS and
        CCD commands.  I don't remember the exact reasons, but those
        were required for the LAM architectures.  /usr/include/mpi
        should be a symlink to /usr/include/lam, but for some reason
        that didn't work.  I think it's a worthy goal to try to remove
        that for the next upload, but would rather leave it in for this
        one.
      * In libptscotch-5.1.install, int/lib/libpt*.so is ambiguous: it
        includes both the versioned shared libraries and the symlinks
        which belong in the -dev package.  If those file names are
        ambiguous, then only the package order determines which files go
        into which package, and that is not good.  Same for
        libscotch-5.1.install.
      * Ah, I see you removed all .so symlinks from the -dev packages,
        which is where they belong.  So I'm going to ignore
        your .install file changes, which are otherwise cosmetic.

I should be able to proceed later today.

-Adam
-- 
GPG fingerprint: D54D 1AEE B11C CE9B A02B  C5DD 526F 01E8 564E E4B6

Engineering consulting with open source tools
http://www.opennovation.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20110401/a2c34257/attachment-0001.pgp>