Bug#657789: python-tables: Enable bzip2 and lzo compressors

[Antonio Valentino]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Frédéric,

Il 31/01/2012 10:29, Picca Frédéric-Emmanuel ha scritto:
> Le Mon, 30 Jan 2012 23:39:27 +0100, Antonio Valentino
> <antonio.valentino at tiscali.it> a écrit :
> 
>> Hi Frédéric,
>> 
>> Il 29/01/2012 10:33, Picca Frédéric-Emmanuel ha scritto:
>>> Package: python-tables Version: 2.3.1-1 Followup-For: Bug
>>> #657789
>>> 
>>> Hello,
>>> 
>>> I saw your proposed patch.
>>> 
>>> +import platform + + # Using ``setuptools`` enables lots of
>>> goodies, such as building eggs. + if 'FORCE_SETUPTOOLS' in
>>> os.environ: +@@ -127,8 +128,14 @@ +
>>> add_from_flags("LDFLAGS", "-L", default_library_dirs)
>>> 
>>> it seems that the upstream can add path provided from the
>>> LDFLAGS, so the best thinks to do is to use the multiarch [1]
>>> instead of patching the code.
>>> 
>> 
>> Do you mean adding something like
>> 
>> LDFLAGS += -L/usr/lib/$(dpkg-architecture -qDEB_HOST_MULTIARCH)
>> 
>> in debian/rules? Yes it seems to be a solution by far cleaner. 
>> Thank you very much.
> 
> yes something like that with an export in front export LDFLAGS ?=
> -L/usr/lib/$(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
> 

Understood, thanks.

>> 
>> On the other end I would like do add a better support for
>> multiarch systems upstream, an in that case I can't rely on
>> dpkg-architecture.
>> 
>> Any idea on how to do it in a general and safe way?
> 
> usually pkg-config[1] is the solution for this sort of things. but
> I check the lzo package and it doesn not provide the .pc file.
> Maybe I should fill a but for thoses library without .pc files. 
> nevertheless the multiarch support is completly Debian specific for
> now...
> 
> So to my opinion, the pkg-config is the solution and when there is
> no pkg-config support of third party libraries. Allow to use the
> LDFLAGS, CFLAGS for fine tuning.
> 
> I hope it answer you question :)
> 
> See you
> 
> Frederic
> 
> [1] http://www.freedesktop.org/wiki/Software/pkg-config
> 
> 

Oh thanks, I didn't considered the possibility to use pkg-config.
I have to think a little more about it,
I'm not 100% sure that it is a good idea to depend/rely on something
that is extern to python itself ... at lease at upstream level.


cheers

- -- 
Antonio Valentino
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk8oZIQACgkQ1JUs2CS3bP7/MQCgs3LvTxP/XovX4Pr+bU2ICHAM
b9kAn0r6coYHJlbYpNSFk9P2S0LiXEu6
=ycHO
-----END PGP SIGNATURE-----