Bug#662792: Bug#616928: openturns_0.15-2.1 NMU

[Aron Xu]

On Fri, Mar 30, 2012 at 22:03, Jakub Wilk <jwilk at debian.org> wrote:
> (I'm not the maintainer, just a neutral observer.)
>
> [...]
>
> This is not appropriate for an NMU either, especially when you introduce new
> bugs:
>
> - You use DEB_HOST_* variables without defining them.
>
> - You use DEB_HOST_* variables though you really should use DEB_BUILD_*
> ones.
>
> - If you really need to want know number of cores (why?), use “getconf
> _NPROCESSORS_ONLN” instead of parsing /proc/cpuinfo.
>
> - You are not supposed to modify DEB_BUILD_OPTIONS in debian/rules...
>
> - ...especially not when you modify it in such a way its value is not policy
> compliant anymore.
>

After using "getconf _NPROCESSORS_ONLN", all of these are gone.

I will make a team upload so everything is "appropriate" (I'm a
member), is this what expected?

>
> Now looking at the diff:
>

Let me reply the following things:

> - You converted to source format 3.0 (quilt), which is not documented in the
> changelog.
>
> - You bumped B-D on debhelper to >= 8, which is not documented.
>
> - You added B-D on autoconf, which is not documented.
>
> - You bumped S-V to 3.9.3, which is not documented.
>
> - You dropped some Section fields from binary stanzas in debian/control,
> which is not documented.
>
> - You removed debain/dirs, which is not documented.
>
> - You stripped debian/tmp prefixes and made other cosmetic changes in
> debian/*.install files, which is not documented.
>

This makes the package build again, not cosmetic, please check details
before saying such thing.

> - You added “-Wl,--as-needed” to LDFLAGS, which is not documented.
>
> - You ignore test failures. Why?
>

It weren't doing any test before, at all.

> - /usr/lib/openturns/libOT.a is not installed anymore. Why? This is not
> documented.
>
> - *.m4 files were moved from /usr/share/openturns/m4/m4/ to
> /usr/share/openturns/m4/. While use of the former path was arguably a bug,
> this is not documented.
>
> - AUTHORS, README and TODO files are not installed anymore. Why? This is not
> documented.
>
> - *.py files in openturns-examples are not bytecompiled anymore. This is not
> documented.
>
> - libopenturns-dbg provides detached debugging information only for
> libopenturns0 (rather than for all packages as it used to). Why? This is not
> documented.
>

The reason here is that changes in Sid has made those debug info does
not work anymore, if you insist on having the details I can write for
you.



-- 
Regards,
Aron Xu