Bug#869975: [opencv] bug in debian/rules -> it isn't compiled with OPENGL=ON

[Mattia Rizzolo]

Control: found -1 3.2.0+dfsg-1~exp1
Control: tag -1 patch

On Fri, Jul 28, 2017 at 12:21:32PM +0200, Jean Jacques BRUCKER wrote:
> Source: opencv
> Version: 2.4.9.1+dfsg1-2

That's also true for the version in experimental (which is the one we
care about, as we're "about" to do a transition to it.

> There should be missing an "else" in debian/rules which implies
> WITH_OPENGL is always ON for ubuntu (overriding previous if-else
> statement) and always undefined for other distributions.

ISTR the KDE/Qt team wants to also apply that change that is done in
ubuntu in debian as well, and also something about arm64.  I'd like to
ask them about this, maybe that "if ubuntu" check should be
dropped.

> Here is the fix: 
> 
> --- a/debian/rules
> +++ b/debian/rules
> @@ -33,6 +33,7 @@ CMAKE_ARCH_FLAGS += -DWITH_OPENGL=ON
>  else
>  CMAKE_ARCH_FLAGS += -DWITH_OPENGL=OFF
>  endif
> +else
>  CMAKE_ARCH_FLAGS += -DWITH_OPENGL=ON
>  endif

Thanks for the patch!


-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/debian-science-maintainers/attachments/20170728/93ababa0/attachment-0001.sig>