Bug#1068385: harp: FTBFS due to -Werror=implicit-function-declaration.

[Bas Couwenberg]

Source: harp
Version: 1.21-1
Severity: serious
Tags: upstream ftbfs patch
Justification: makes the package in question unusable or mostly so
User: debian-gis at lists.debian.org
Usertags: hdf-4.3

Dear Maintainer,

Your package FTBFS while performing test rebuilds with HDF 4.3.20.

The attached patch resolves the issue by adding the appropriate includes to fix the -Werror=implicit-function-declaration issues.

Kind Regards,

Bas
-------------- next part --------------
diff -Nru harp-1.21/debian/changelog harp-1.21/debian/changelog
--- harp-1.21/debian/changelog	2024-03-16 08:16:08.000000000 +0100
+++ harp-1.21/debian/changelog	2024-04-04 12:59:55.000000000 +0200
@@ -1,3 +1,10 @@
+harp (1.21-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Rebuild with HDF 4.3.0.
+
+ -- Bas Couwenberg <sebastic at debian.org>  Thu, 04 Apr 2024 12:59:55 +0200
+
 harp (1.21-1) unstable; urgency=medium
 
   * New upstream release
diff -Nru harp-1.21/debian/patches/implicit-function-declaration.patch harp-1.21/debian/patches/implicit-function-declaration.patch
--- harp-1.21/debian/patches/implicit-function-declaration.patch	1970-01-01 01:00:00.000000000 +0100
+++ harp-1.21/debian/patches/implicit-function-declaration.patch	2024-04-04 12:59:55.000000000 +0200
@@ -0,0 +1,13 @@
+Description: Fix FTBFS due to -Werror=implicit-function-declaration.
+Author: Bas Couwenberg <sebastic at debian.org>
+
+--- a/libharp/harp-hdf4.c
++++ b/libharp/harp-hdf4.c
+@@ -33,6 +33,7 @@
+ 
+ #include <assert.h>
+ #include <stdlib.h>
++#include <string.h>
+ 
+ #include "hdf.h"
+ #include "mfhdf.h"
diff -Nru harp-1.21/debian/patches/series harp-1.21/debian/patches/series
--- harp-1.21/debian/patches/series	2024-03-16 08:16:08.000000000 +0100
+++ harp-1.21/debian/patches/series	2024-04-04 12:59:55.000000000 +0200
@@ -5,3 +5,4 @@
 python3.patch
 multiarch.patch
 udunits-path.patch
+implicit-function-declaration.patch