[xml/sgml-pkgs] Bug#681163: Bug#681163: libxslt: LDFLAGS hardening flags missing for dbg package

[Aron Xu]

On Fri, Jul 13, 2012 at 3:26 AM, Simon Ruderich <simon at ruderich.org> wrote:
> On Thu, Jul 12, 2012 at 12:11:41PM +0800, Aron Xu wrote:
>> Hi Simon,
>>
>> Thanks for your care, but I'm still not sure how useful to enable
>> hardening in -dbg package, and I'm not sure if it will make debugging
>> more difficult? The use of -O0 was deliberate by previous libxslt
>> maintainer and I agree with such assessment at least for now.
>
> Hello Aron,
>
> -O0 is still used with my patch because later optimization flags
> override previous ones.
>
> Hardening flags shouldn't make debugging more difficult because
> no unfriendly optimizations take place and if -dbg and non-debug
> package are built with the same flags no unexpected behavioral
> changes happen (e.g. crash in non-debug package because
> stack-protector is used but no crash in -dbg package; one
> exception are the CPPFLAGS which are disabled with -O0).
>
> And using hardening flags for the complete package make automatic
> checks for missing flags (e.g. blhc) possible.
>
> Regards,
> Simon
> --
> + privacy is necessary
> + using gnupg http://gnupg.org
> + public key id: 0x92FEFDB7E44C32F9

Thanks for your detailed explanation! I'll incorporate this change in
my next upload, but I'm can't promise when it will happen.

-- 
Regards,
Aron Xu