[Debichem-devel] gabedit - proposed patch for sprintf abuse

[Nicholas Breen]

A recent post on debian-devel [1] highlighted a fairly common, but
technically incorrect use of sprintf() that was causing some breakage in
Ubuntu.  One of the packages was gabedit, and it's actually got more
problems than the check indicated - it's using a fair number of calls
such as:
  sprintf(buf, "%s----", buf);
instead of the more straightforward
  strcat(buf, "----");
...for unknown reasons.

Attached is a patch that fixes all the problems either by fixing up the
sprintf syntax or by replacement with strcat.  Probably worth sending
upstream.  Daniel - want me to add it as a dpatch to the SVN repo?


[1] http://lists.debian.org/debian-devel/2008/12/msg01079.html


-- 
Nicholas Breen
nbreen at ofb.net
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gabedit-sprintf.patch
Type: text/x-diff
Size: 8224 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/debichem-devel/attachments/20081231/2bb47772/attachment.patch