[Debichem-devel] bagel_0.0~git20150902-1_amd64.changes REJECTED

Michael Banck mbanck at debian.org
Sun Jan 17 20:09:40 UTC 2016


Hi Thorsten,

thanks for the review and sorry for the trouble.

On Thu, Dec 17, 2015 at 04:00:16PM +0000, Thorsten Alteholz wrote:
> Several files under src/* are licensed under a BSD license. 
> Please mention them in your debian/copyright.

Thanks, I had them as LGPL-2.1 but missed that they have also a BSD
copyright header. I've added that now.
 
> According to the file header, lots of file in src/* are licenced 
> under LGPL-3+. Please also mention them in your debian/copyright.

Apparently I was caught off-guard by the README and the main COPYING
file which read GPL-3.  It seems all the source code is actually LGPL-3
unless otherwise noted and I filed a Github issue for upstream to act on.

I have uploaded bagel with a fixed debian/copyright and two minor
additions (debian/bagel.examples and debian/upstream/metadata), see the
attached debdiff since the last upload for your convenience.


Cheers,

Michael
-------------- next part --------------
diff -Nru bagel-0.0~git20150902/debian/bagel.examples bagel-0.0~git20150902/debian/bagel.examples
--- bagel-0.0~git20150902/debian/bagel.examples	1970-01-01 01:00:00.000000000 +0100
+++ bagel-0.0~git20150902/debian/bagel.examples	2015-09-10 20:25:54.000000000 +0200
@@ -0,0 +1 @@
+test/*.json
diff -Nru bagel-0.0~git20150902/debian/changelog bagel-0.0~git20150902/debian/changelog
--- bagel-0.0~git20150902/debian/changelog	2015-09-09 16:53:18.000000000 +0200
+++ bagel-0.0~git20150902/debian/changelog	2016-01-17 13:07:42.000000000 +0100
@@ -2,4 +2,4 @@
 
   * Initial release (Closes: #797798)
 
- -- Michael Banck <mbanck at debian.org>  Wed, 09 Sep 2015 16:53:09 +0200
+ -- Michael Banck <mbanck at debian.org>  Sun, 17 Jan 2016 13:04:30 +0100
diff -Nru bagel-0.0~git20150902/debian/copyright bagel-0.0~git20150902/debian/copyright
--- bagel-0.0~git20150902/debian/copyright	2015-09-08 23:22:51.000000000 +0200
+++ bagel-0.0~git20150902/debian/copyright	2016-01-17 13:02:41.000000000 +0100
@@ -10,7 +10,7 @@
            2012-2013 Michael Caldwell
            2013      Ryan Reynolds
            2014      Jefferson Bates
-License: GPL-3+
+License: LGPL-3+
 
 Files: src/alglib/*
 Copyright: 2005-2013 Sergey Bochkanov
@@ -20,32 +20,33 @@
 Copyright: 1984-2000 by Stephen L. Moshier
 License: GPL-2+
 
-Files: carsph_gen/mpreal.h comprys/interpolate/mpreal.h
- ecp/testcode/ang_proj/mpreal.h ecp/carsph/mpreal.h
- ecp/wigner3j_gen/mpreal.h rys/interpolate/mpreal.h
+Files: src/integral/carsph_gen/mpreal.h
+ src/integral/comprys/interpolate/mpreal.h
+ src/integral/ecp/testcode/ang_proj/mpreal.h src/integral/ecp/carsph/mpreal.h
+ src/integral/ecp/wigner3j_gen/mpreal.h src/integral/rys/interpolate/mpreal.h
 Copyright: 2008-2012 Pavel Holoborodko
-License: LGPL-2.1+
+License: LGPL-2.1+, BSD-3
 
 Files: debian/*
 Copyright: 2013 Michael Banck <mbanck at debian.org>
 License: GPL-3+
 
-License: GPL-3+
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation, either version 3 of the License, or
- (at your option) any later version.
+License: LGPL-3+
+ This package is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 3 of the License, or (at your option) any later version.
  .
  This package is distributed in the hope that it will be useful,
  but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- GNU General Public License for more details.
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ Lesser General Public License for more details.
  .
  You should have received a copy of the GNU General Public License
  along with this program. If not, see <http://www.gnu.org/licenses/>.
- .
- On Debian systems, the complete text of the GNU General
- Public License version 2 can be found in "/usr/share/common-licenses/GPL-3".
+Comment:
+ On Debian systems, the complete text of the GNU Lesser General Public
+ License version 3 can be found in `/usr/share/common-licenses/LGPL-3'.
 
 License: GPL-2+
  This package is free software; you can redistribute it and/or modify
@@ -61,8 +62,8 @@
  You should have received a copy of the GNU General Public License
  along with this program. If not, see <http://www.gnu.org/licenses/>
  .
- On Debian systems, the complete text of the GNU General
- Public License version 2 can be found in "/usr/share/common-licenses/GPL-3".
+Comment: On Debian systems, the complete text of the GNU General Public License
+ version 2 can be found in the file  `/usr/share/common-licenses/GPL-2'.
 
 License: LGPL-2.1+
  This library is free software; you can redistribute it and/or
@@ -80,3 +81,28 @@
  Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
 Comment: On Debian systems the complete text of the GNU Lesser General Public
  License 2.1 can be found in the file `/usr/share/common-licenses/LGPL-2.1'.
+
+License: BSD-3
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+ .
+ * Redistributions of source code must retain the above copyright notice,
+   this list of conditions and the following disclaimer.
+ * Redistributions in binary form must reproduce the above copyright notice,
+   this list of conditions and the following disclaimer in the documentation
+   and/or other materials provided with the distribution.
+ * Neither the name of NextWindow nor the names of its contributors may be
+   used to endorse or promote products derived from this software without
+   specific prior written permission.
+ .
+ THIS SOFTWARE IS PROVIDED BY NEXTWINDOW LTD ``AS IS'' AND ANY EXPRESS OR
+ IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN
+ NO EVENT SHALL NEXTWINDOW LTD BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
+ OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
+ WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
+ OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
+ ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff -Nru bagel-0.0~git20150902/debian/upstream/metadata bagel-0.0~git20150902/debian/upstream/metadata
--- bagel-0.0~git20150902/debian/upstream/metadata	1970-01-01 01:00:00.000000000 +0100
+++ bagel-0.0~git20150902/debian/upstream/metadata	2015-09-10 20:25:54.000000000 +0200
@@ -0,0 +1,6 @@
+Name: BAGEL
+Homepage: http://www.nubakery.org/
+Reference:
+ - Title: "BAGEL, Brilliantly Advanced General Electronic-structure Library. http://www.nubakery.org under the GNU General Public License."
+   Year: 2015
+   URL: http://www.nubakery.org/


More information about the Debichem-devel mailing list