Bug#728198: devscripts: debuild (& others) must reject debian/rules actions on unpatched source trees

[Ximin Luo]

On 29/10/13 14:23, Bill Allombert wrote:
> On Tue, Oct 29, 2013 at 12:14:16PM +0000, Ximin Luo wrote:
>> Package: devscripts
>> Version: 2.13.4
>> Severity: important
>>
>> It does not make sense to build or clean an unpatched source tree, since the
>> applied patches are considered strictly *part of the source package*. However,
>> `debuild build/clean`, and probably many other tools, still allows this to
>> happen without any warning.
> 
> I think I understand Ximin issue:
> 
> debclean can fail in a source tree when using the source format "3.0 quilt",
> if 'debian/rules clean' requires the patches to be applied to work, for example
> an upstream Makefile is fixed,
> because debclean does not make sure the patches are applied.
> 
> Cheers,
> 

Thanks, Bill! Yes that's what I meant.

One possible way to fix this, is to change `debuild $TARGET` so that it runs:

$ dpkg-source --before-build
$ debian/rules $TARGET
$ dpkg-source --after-build

instead of just `debian/rules $TARGET`.

This works for my use case, but I'm less certain if it is "completely correct".

-- 
GPG: 4096R/1318EFAC5FBBDBCE
git://github.com/infinity0/pubkeys.git

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20131029/282c5432/attachment.sig>