Bug#736476: uscan: always downloads signature files over HTTP

[Peter Eisentraut]

Package: devscripts
Version: 2.13.9
Severity: normal

uscan supports ftp and http URLs for the main package file, but the
OpenPGP signature file is always downloaded over HTTP, even if it's
using an ftp URL, which fails.  The same conditional logic that is
used for the main download needs to be applied for the signature file.

While we're at is, the error message is also wrong:

uscan_warn "$progname warning: In directory $pkg_dir, downloading OpenPGP signature\n  $upstream_url failed: " . $sigresponse->status_line . "\n";

even though it was actually downloading $pgpsig_url.  Looks like copy
and paste.


-- System Information:
Debian Release: jessie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (101, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.10-3-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages devscripts depends on:
ii  dpkg-dev     1.17.5
ii  libc6        2.17-97
ii  perl         5.18.1-5
ii  python3      3.3.2-17
pn  python3:any  <none>

Versions of packages devscripts recommends:
pn  at                          <none>
ii  curl                        7.34.0-1
ii  dctrl-tools                 2.23
ii  debian-keyring              2013.12.13
ii  dput                        0.9.6.4
ii  dupload                     2.7.0
ii  equivs                      2.0.9
ii  fakeroot                    1.18.4-2
ii  gnupg                       1.4.15-3
ii  libdistro-info-perl         0.11
ii  libencode-locale-perl       1.03-1
ii  libjson-perl                2.61-1
ii  liblwp-protocol-https-perl  6.04-2
ii  libparse-debcontrol-perl    2.005-4
ii  libsoap-lite-perl           0.716-1
ii  liburi-perl                 1.60-1
ii  libwww-perl                 6.05-2
ii  lintian                     2.5.20
ii  man-db                      2.6.5-2
ii  patch                       2.7.1-4
ii  patchutils                  0.3.2-3
ii  python3-debian              0.1.21+nmu2
ii  python3-magic               1:5.14-2
ii  sensible-utils              0.0.9
ii  strace                      4.5.20-2.3
ii  unzip                       6.0-10
ii  wdiff                       1.2.1-1
ii  wget                        1.14-5
ii  xz-utils                    5.1.1alpha+20120614-2

Versions of packages devscripts suggests:
ii  bsd-mailx [mailx]            8.1.2-0.20131005cvs-1
ii  build-essential              11.6
pn  cvs-buildpackage             <none>
pn  devscripts-el                <none>
ii  gnuplot                      4.6.4-1
ii  gpgv                         1.4.15-3
ii  libauthen-sasl-perl          2.1500-1
ii  libfile-desktopentry-perl    0.07-1
ii  libnet-smtp-ssl-perl         1.01-3
ii  libterm-size-perl            0.207-1+b1
ii  libtimedate-perl             2.3000-1
ii  libyaml-syck-perl            1.27-2+b1
pn  mutt                         <none>
ii  openssh-client [ssh-client]  1:6.4p1-2
ii  svn-buildpackage             0.8.5
ii  w3m                          0.5.3-12

-- no debconf information