Bug#754203: mk-origtargz (Was: Problem with *.zip archives)

[Andreas Tille]

Hi,

anynody working on the JAR issue.  I tried the following:

$ apt-get source varscan

$ uscan --verbose --force-download --repack --compress xz
...
Newest version on remote site is 2.3.7, local version is 2.3.6+dfsg
 (mangled local version number 2.3.6)
 => Forcing download as requested
-- Downloading updated package VarScan.v2.3.7.source.jar
-- Checking for common possible upstream OpenPGP signatures
Use of uninitialized value $mime in string eq at /usr/bin/mk-origtargz line 315.
Parameter ../VarScan.v2.3.7.source.jar does not look like a tar archive or a zip file. at /usr/bin/mk-origtargz line 320.
uscan: error: mk-origtargz --package varscan --version 2.3.7 --repack --compression xz --directory .. --copyright-file debian/copyright ../VarScan.v2.3.7.source.jar gave error exit status 255
debian/rules:19: recipe for target 'get-orig-source' failed
make: *** [get-orig-source] Error 255


Now I tried to trick mk-origtargz by a simple:

$ ln -s VarScan.v2.3.7.source.jar ../VarScan.v2.3.7.source.zip
$ mk-origtargz --repack --compress xz ../VarScan.v2.3.7.source.zip
Use of uninitialized value $mime in string eq at /usr/bin/mk-origtargz line 315.
Parameter ../VarScan.v2.3.7.source.zip does not look like a tar archive or a zip file. at /usr/bin/mk-origtargz line 320.


But a JAR file is actually a ZIP file since

$ unzip ../VarScan.v2.3.7.source.zip

(== the symlinked JAR perfectly works).

I wonder whether anybody is working on this.  I might try with my poor
Perl skills but since I consider the problem very easy to fix it might
be more straightforward if some proper Perl code gets in initially.

Kind regards

       Andreas.

On Thu, Apr 17, 2014 at 05:50:39PM +0200, Joachim Breitner wrote:
> Hi,
> 
> Am Sonntag, den 13.04.2014, 21:59 -0400 schrieb James McCoy:
> > On Sun, Apr 13, 2014 at 5:37 AM, Joachim Breitner <nomeata at debian.org> wrote:
> > > done, looks like the code was actually working quite well. Merged into
> > > master, to give it some testing. Feel free to play around with it now,
> > > if you are so inclined.
> > 
> > I'll review it next week, after I return from vacation.  Thanks for
> > the contribution!
> 
> I now made uscan use the new script, removing lots of code from uscan:
>  2 files changed, 71 insertions(+), 356 deletions(-)
> 
> The testsuite works, but of course that does not say a lot. I’m sure
> Andreas will tell me what else I broke :-). I also need to fix up the
> build dependencies in README and Description.
> 
> Andreas: Minor change: Downloaded zipfiles are not deleted unless you
> specify "--rename". I find this more consistent to how downloaded
> unrepackaged tarfiles are left around unless you use "--rename".
> 
> Greetings,
> Joachim
> 
> 
> -- 
> Joachim "nomeata" Breitner
> Debian Developer
>   nomeata at debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
>   JID: nomeata at joachim-breitner.de | http://people.debian.org/~nomeata
> 



-- 
http://fam-tille.de