Bug#809662: uscan: Regression when --destdir is set: Can't open 'pkg_version.orig.tar.gz': No such file or directory at /usr/bin/uscan line 3706.

[Salvatore Bonaccorso]

Package: devscripts
Version: 2.15.10
Severity: normal

Hi

I usually run uscan in similar way as:

$ uscan --verbose --force-download --rename --repack --destdir=../tarballs

With the recent update, uscan started failing with the following, with
libsys-virt-perl as an example:

libsys-virt-perl's watchfile is:

version=3
https://metacpan.org/release/Sys-Virt   .*/Sys-Virt-v?(\d[\d.-]+)\.(?:tar(?:\.gz|\.bz2)?|tgz|zip)$

and running uscan exits with:

$ uscan --verbose --force-download --rename --repack --destdir=../tarballs
uscan: uscan (version 2.15.10) See uscan(1) for help
uscan: Scan watch files in .
uscan info: Check debian/watch and debian/changelog in .
uscan info: package="libsys-virt-perl" version="1.3.0-1" (as seen in debian/changelog)
uscan info: package="libsys-virt-perl" version="1.3.0" (no epoch/revision)
uscan: ./debian/changelog sets package="libsys-virt-perl" version="1.3.0"
uscan info: Process ./debian/watch (package=libsys-virt-perl version=1.3.0)
uscan info: Last orig.tar.* tarball version (from debian/changelog): 1.3.0
uscan info: Last orig.tar.* tarball version (dversionmangled): 1.3.0
uscan info: Requesting URL:
   https://metacpan.org/release/Sys-Virt
uscan info: Matching pattern:
   (?:(?:https://metacpan.org)?\/release\/Sys\-Virt)?.*/Sys-Virt-v?(\d[\d.-]+)\.(?:tar(?:\.gz|\.bz2)?|tgz|zip)$
uscan info: Found the following matching hrefs on the web page (newest first):
   https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-1.3.0.tar.gz (1.3.0) index=1.3.0.1
uscan info: Matching target for downloadurlmangle: https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-1.3.0.tar.gz
uscan info: Upstream URL (downloadurlmangled):
   https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-1.3.0.tar.gz
uscan info: Newest upstream tarball version selected for download (uversionmangled): 1.3.0
uscan info: Download filename (filenamemangled): Sys-Virt-1.3.0.tar.gz
uscan: Newest version on remote site is 1.3.0, local version is 1.3.0
uscan:    => Package is up to date
uscan:    => Forcing download as requested
uscan: Downloading upstream package: Sys-Virt-1.3.0.tar.gz
uscan info: Requesting URL:
   https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-1.3.0.tar.gz
uscan: Start checking for common possible upstream OpenPGP signature files
uscan: End checking for common possible upstream OpenPGP signature files
uscan info: Missing OpenPGP signature.
uscan info: New orig.tar.* tarball version (oversionmangled): 1.3.0
uscan: Successfully downloaded package Sys-Virt-1.3.0.tar.gz
uscan info: Executing internal command:
   mk-origtargz --package libsys-virt-perl --version 1.3.0 --rename --repack --compression gzip --directory ../tarballs --copyright-file debian/copyright ../tarballs/Sys-Virt-1.3.0.tar.gz
uscan info: New orig.tar.* tarball version (after mk-origtargz): 1.3.0
Can't open 'Sys-Virt-1.3.0.tar.gz': No such file or directory at /usr/bin/uscan line 3705.
$ echo $?
2

I have not fully looked to all changes affecting scripts/uscan.pl
itself but the following commit introduced the issue (while bisecting
devscripts):

https://anonscm.debian.org/cgit/collab-maint/devscripts.git/commit/?id=f330e171434dd0f6bec8144363ee03d1e92c158d

There were more changes afterwards, but reverting devscripts to the
commit before that change lets uscan behave as previous exiting
successfully:

~/src/collab-maint/devscripts/scripts/uscan.pl --verbose --force-download --rename --repack --destdir=../tarballs
-- Scanning for watchfiles in .
-- Found watchfile in ./debian
-- In debian/watch, processing watchfile line:
   https://metacpan.org/release/Sys-Virt   .*/Sys-Virt-v?(\d[\d.-]+)\.(?:tar(?:\.gz|\.bz2)?|tgz|zip)$
Newest version on remote site is 1.3.0, local version is 1.3.0
 => Package is up to date
Newest version on remote site is 1.3.0, local version is 1.3.0
 => Forcing download as requested
-- Downloading updated package Sys-Virt-1.3.0.tar.gz
-- Checking for common possible upstream OpenPGP signatures
-- Executing internal command
     mk-origtargz --package libsys-virt-perl --version 1.3.0 --rename --repack --compression gzip --directory ../tarballs --copyright-file debian/copyright ../tarballs/Sys-Virt-1.3.0.tar.gz
-- Successfully downloaded updated package Sys-Virt-1.3.0.tar.gz
-- Successfully renamed ../tarballs/Sys-Virt-1.3.0.tar.gz to ../tarballs/libsys-virt-perl_1.3.0.orig.tar.gz.
-- Scan finished

Regards,
Salvatore