Bug#810976: [uscan] Ignores non-zero exitcode of "action"

[Ben Wiederhake]

Package: devscripts
Version: 2.15.9
Severity: normal
File: /usr/bin/uscan

Dear Maintainer,

when using a watchfile with an action, the exit-code is ignored.
This is problematic, because if the "action" is required to produce a working
orig tarball, this silently fails.

Here's the invocation of uscan I used:

    uscan --noconf --verbose --rename --destdir=/home/user/workspace/telegram-
purple \
          --check-dirname-level=0 --force-download --download-version
"1.2.5~beta" \
          /home/user/workspace/telegram-purple/debian

Here's the actual behavior, truncated to the relevant part:

    -- Executing user specified script
         /bin/false --upstream-version 1.2.5~beta /home/eispin/workspace
/telegram-purple/telegram-purple_1.2.5~beta.orig.tar.gz
    -- Scan finished
    user at xpected:~/workspace/telegram-purple$ echo $?
    0

Here's what I would have liked to see:

    -- Executing user specified script
         /bin/false --upstream-version 1.2.5~beta /home/user/workspace
/telegram-purple/telegram-purple_1.2.5~beta.orig.tar.gz
    -- Scan aborted: user specified script failed
    user at xpected:~/workspace/telegram-purple$ echo $?
    1

(or something like it)

The BTS doesn't know anything about this, and 2.15.10 (unstable) doesn't seem
to fix this, according to the changelog.

Regards,
Ben Wiederhake


-- Package-specific info:

--- /etc/devscripts.conf ---

--- ~/.devscripts ---
DEBUILD_DPKG_BUILDPACKAGE_OPTS="-us -uc -I -i"
DEBUILD_LINTIAN_OPTS="-EiI --pedantic --show-overrides"
DEBSIGN_KEYID="CB6A 2523 BF57 5A47 4352  0FA7 2DAE 208A 6034 F1B9"
DEBEMAIL="BenWiederhake.GitHub at gmx.de"
DEBFULLNAME="Ben Wiederhake"

-- System Information:
Debian Release: stretch/sid
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.2.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages devscripts depends on:
ii  dpkg-dev     1.18.4
ii  libc6        2.21-6
ii  perl         5.22.1-3
ii  python3      3.4.3-7
pn  python3:any  <none>

Versions of packages devscripts recommends:
ii  at                          3.1.18-2
ii  curl                        7.46.0-1
pn  dctrl-tools                 <none>
ii  debian-keyring              2015.11.30
ii  dput-ng [dput]              1.10
pn  equivs                      <none>
ii  fakeroot                    1.20.2-1
ii  file                        1:5.25-2
ii  gnupg                       1.4.20-1
pn  libdistro-info-perl         <none>
ii  libencode-locale-perl       1.05-1
ii  libjson-perl                2.90-1
ii  liblwp-protocol-https-perl  6.06-2
pn  libsoap-lite-perl           <none>
ii  liburi-perl                 1.69-1
ii  libwww-perl                 6.15-1
ii  lintian                     2.5.39.1
ii  man-db                      2.7.5-1
ii  patch                       2.7.5-1
ii  patchutils                  0.3.4-1
ii  python3-debian              0.1.27
ii  python3-magic               1:5.25-2
ii  sensible-utils              0.0.9
ii  strace                      4.10-3
ii  unzip                       6.0-20
ii  wdiff                       1.2.2-1+b1
ii  wget                        1.17.1-1
ii  xz-utils                    5.1.1alpha+20120614-2.1

Versions of packages devscripts suggests:
[SNIP -- irrelevant]