Bug#812860: /usr/bin/uscan: [uscan] failure to download and verify package.tar.xz with package.sign

[Uwe Kleine-König]

Hello Osamu,

On 01/31/2016 09:41 AM, Osamu Aoki wrote:
> I think I have fix for this bug report.

Thanks for you quick reaction.

> On Sun, Jan 31, 2016 at 08:03:22AM +0900, Osamu Aoki wrote:
>> On Wed, Jan 27, 2016 at 10:26:49PM -0500, James McCoy wrote:
> 
> Your comment on --force-download is correct.
> 
>>> Thanks for the report.  There are a few things going on here.
>>>
>>> On Wed, Jan 27, 2016 at 11:36:52AM +0100, Uwe Kleine-König wrote:
>>>> now running
> 
> [snip]
>  
>>>> 	uscan: Successfully downloaded package rt-tests-0.96.tar.xz
>>>> 	Could not read ../rt-tests-0.96.tar.xz: No such file or directory at /usr/bin/mk-origtargz line 361.
>>>> 	uscan: error: mk-origtargz --package rt-tests --version 0.96 --compression gzip --directory .. --copyright-file debian/copyright ../rt-tests-0.96.tar.xz gave error exit status 2
>>>>
>>>> where the problem seems to be that uscan decompresses the archive but in
>>>> the same go removes the tar.xz for mk-origtargz.
>>>
>>> Actually, it keeps the tar.xz when it should be passing the filename as
>>> rt-tests-0.96.tar, if the current verification behavior isn't changed.
> 
> uscan keeps filename for tar.xz in its internal variable but
> gunzip/unxz/bunzip2 were invoked without --keep in uscan

I tested your change, and it works fine here now. \o/

> Script started on Sun 31 Jan 2016 05:23:24 PM JST
> [...]
> uscan info: Matching pattern:
>    (?:(?:http://www.kernel.org)?\/pub\/linux\/utils\/rt\-tests\/)?rt-tests-(.*)\.tar\.xz (?:(?:https://www.kernel.org)?\/pub\/linux\/utils\/rt\-tests\/)?rt-tests-(.*)\.tar\.xz

Using (?:.....)? at the start of a regexp doesn't give any advantage,
and probably can be dropped without any loss. If you want to keep it:
Why is the - quoted? You might want to make "http:" optional, because
otherwise

	//www.kernel.org/pub/linux/utils/rt-tests/...

isn't matched.

Best regards
Uwe

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 455 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/devscripts-devel/attachments/20160131/9076499b/attachment-0002.sig>