Bug#809318: bts: overrides user-specified value of sendmail

[Daniel Shahaf]

Osamu Aoki wrote on Thu, Mar 10, 2016 at 11:52:32 +0000:
> Then its fix should be "die" instead of stop doing sanity check.
> 
> What do you think of attached patch.

+1.  Your patch would resolve the issue and seems to be the least
intrusive way to do so.

One comment, below:

> -	    warn "BTS_SENDMAIL_COMMAND contained funny characters: $cmd\nReverting to default value /usr/sbin/sendmail\n";
> -	    $config_vars{'BTS_SENDMAIL_COMMAND'}='/usr/sbin/sendmail';
> +	    die "BTS_SENDMAIL_COMMAND contained funny characters: $cmd\nPlease fix configuration file.\n";

The noun phrase "configuration file" needs an article: it should say
"Please fix your configuration file" or "Please fix the configuration
file".

Thanks,

Daniel