<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</p>
<pre style="margin: 1.5em 0px; padding: 0px; border: 0px; outline: 0px; font-weight: normal; font-style: normal; font-size: 13px; font-family: monospace; vertical-align: baseline; overflow: auto; white-space: pre; color: black; font-variant: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255);">Package: devscripts
Version: devscripts-2.16.5<pre class="bz_comment_text
bz_wrap_comment_text" id="comment_text_0" style="font-size: small; font-family: monospace; white-space: pre-wrap; word-wrap: break-word; width: 50em; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></pre>Following is a trimmed version of the downstream bug at <a class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=1350021">https://bugzilla.redhat.com/show_bug.cgi?id=1350021</a> :
<meta http-equiv="content-type" content="text/html; charset=utf-8">Description of problem:
When licensecheck ran, it reported:
find: File system loop detected; ‘./src/giac’ is part of the same file system loop as ‘./src’.
Can't close(GLOB(0x668db0)) filehandle: '' at /usr/bin/licensecheck line 387
There are two bugs here: licensecheck tries to close a file handle on line 387 even when the handle is already closed due to find exiting with an error, and licensecheck invokes find with the -follow option.
The find man page says that -follow is deprecated and -L should be used instead, by the way. But I can't conceive of any situation where using -follow/-L is the right thing to do. I think it should be removed, for three reasons. Reason 1: self loops like the one in giac make find, and therefore licensecheck, fail. Reason 2: symlinks can point anywhere. Do you really want to let licensecheck run over arbitrary parts of the filesystem? Reason 3: every file in a package *should* be reachable without traversing symlinks at all. (If fedora-review doesn't have a check for that, it probably should.)
Steps to Reproduce:
1. mkdir loop
2. ln -s . loop/loop
3. licensecheck -r -v loop
Actual results:
The error messages reported above, and no license output.
Expected results:
A report on licenses.
Additional info:
The filesystem type might have something to do with this. I do NOT see this behavior if I create the loop under /tmp (tmpfs), but I do see it if the loop is under my /home directory (ext4).<pre class="bz_comment_text
bz_wrap_comment_text" id="comment_text_0" style="font-size: small; font-family: monospace; white-space: pre-wrap; word-wrap: break-word; width: 50em; color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px;"></pre>
</pre></body></html>