[Foo2zjs-maintainer] Bug#558978: Bug#558978: foo2zjs: fix the udev rules installation

[Luca Capello]

tags 558978 + pending
thanks

Hi Steve!

I cc:ed everyone involved with this bug for testing, if you do not want
to read the whole mail, please skip to the end.

On Tue, 01 Dec 2009 01:53:23 +0100, Steve Langasek wrote:
> The Ubuntu version of the foo2zjs package currently contains a considerable
> delta relative to the Debian package, and it would be good to bring some of
> this delta down.  Please find attached what I expect will be the first in a
> series of patches to that end.

Thank you for the patch, which I have applied completely, see comments
below:

  http://svn.debian.org/viewsvn/foo2zjs?view=rev&revision=204

>     - debian/rules, debian/85-hplj10xx.rules: move the rules from
>       11-hplj10xx.rules to 85-hplj10xx.rules per /etc/udev/rules.d/README,

I could not find /etc/udev/rules.d/README in any Debian or Ubuntu
distribution, was it /usr/share/doc/udev/README.Debian.gz?

> Since the udev rules file is at this point a complete rewrite of the
> original, we've found it easier to ship a separate file under debian/
> instead of continuing to patch the upstream one with dpatch; your mileage
> may vary.  Ideally, these changes would all be pushed upstream in any event.

I still prefer to continue patching upstream one, because it is easier
to know what we changed and moreover these changes clearly show up on
<http://patch-tracker.debian.org/> (currently down).  Besides that, I
dislike lines longer than 72 characters ;-)

Other comments on your patch:

1) it includes support for the HP LaserJet P1505n via the
   /usr/sbin/hpljP1505n symlink, but the latter is not present in the
   Ubuntu package: according to upstream, support for this printer has
   been added in version 20100306, you may want to fix it.

2) it adds debian/foo2zjs.preinst to remove, when installing or
   upgrading, the old udev rules file if it has not been locally
   modified.  I added a debian/changelog entry reflecting this.

FWIW, I will convert the package to use quilt instead of dpatch,
not only to maybe eventually moving to the dpkg v3.0 (quilt) format.

On my virtual sid, at least the error messages at boot are gone, but
since I do not have any of the printers requiring the udev rules file,
i386 and amd64 packages for testing are available at:

  http://people.debian.org/~gismo/tmp/

Thx, bye,
Gismo / Luca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/foo2zjs-maintainer/attachments/20100307/77a9fe25/attachment.pgp>