Bug#634401: extundelete: FTBFS: extundelete.cc:963:47: error: invalid use of incomplete type 'struct opaque_ext2_group_desc'

[Ted Ts'o]

On Tue, Jan 03, 2012 at 11:54:46AM -0600, Eric Sandeen wrote:
> > 
> > I just investigated on this FTBFS issue.
> > 
> > The problem is that extundelete doesn't compile against e2fslibs-dev
> > versions >=1.42. Therefore extundelete was just removed from
> > Debian/testing, so if this bug can't be resolved then extundelete
> > sadly can't be shipped with the upcoming Debian stable release.

The extundelete program also needs to be changed to support 64-bit
file systems.

> > The responsible change in e2fslibs-dev is this one ("libext2fs: make
> > fs->group_desc opaque"):
> > 
> >   http://git.kernel.org/?p=fs/ext2/e2fsprogs.git;a=commit;h=efe0b401465a3ee836180614b5b435acbb84fc27
> > 
> > The commit message talks about EXT2FS_OLD_32_COMPAT which should
> > provide compiling of "Old-style applications who don't want to
> > change their source code". Sadly EXT2FS_OLD_32_COMPAT wasn't
> > implemented in this commit nor in a following one.
> 
> Hm, none of that was in my original commit or message, I think
> Ted added that text on commit, but didn't modify the patch at all.

Yeah, somehow that change got lost.  I'm not sure what happened.

> There are other problems though, I think, in parse_inode_block() for example,
> things in there have changed as well... this tool seems to be getting a little
> to grubby in the ext internals.  I think maybe it should be making
> use of ext2fs_swap_inode() instead.
> 
> > The issue was brought up on the mailinglist of extundelete a few
> > weeks ago, but there wasn't a reaction from upstream since then.
> > 
> > Eric and Theodore - any ideas what's the best way to resolve this
> > issue in the meanwhile?

I'll look at trying to add the backwards compatibility support back
into a future version of e2fsprogs, but really, extundelete should be
updated to use the accessor functions and updated to support 64-bit
file systems.

					- Ted