kov changed libgksu/trunk/ChangeLog, libgksu/trunk/libgksu/libgksu.c

[Gustavo Noronha]

Mensagem de log: 
preventing possible segfaults


-----


Modified: libgksu/trunk/ChangeLog
===================================================================
--- libgksu/trunk/ChangeLog	2006-05-01 13:54:49 UTC (rev 605)
+++ libgksu/trunk/ChangeLog	2006-05-01 14:31:29 UTC (rev 606)
@@ -1,5 +1,10 @@
 2006-05-01  Gustavo Noronha Silva  <kov at debian.org>
 
+	* libgksu/libgksu.c:
+	- check fread's return value before using strlen
+	  and setting a \0 in the xauth string, to prevent
+	  problems when xauth returns nothing (#7698)
+
 	* Release 1.9.2
 
 	* configure.ac:

Modified: libgksu/trunk/libgksu/libgksu.c
===================================================================
--- libgksu/trunk/libgksu/libgksu.c	2006-05-01 13:54:49 UTC (rev 605)
+++ libgksu/trunk/libgksu/libgksu.c	2006-05-01 14:31:29 UTC (rev 606)
@@ -1089,8 +1089,8 @@
 	       strerror(errno));
       return 1;
     }
-  fread (xauth, sizeof(char), 256, xauth_output);
-  xauth[strlen(xauth) - 1] = '\0';
+  if (fread (xauth, sizeof(char), 256, xauth_output))
+    xauth[strlen(xauth) - 1] = '\0';
   pclose (xauth_output);
   g_free (tmp);