[PATCH] New function: find_k_nearest()

martin f krafft madduck at debian.org
Tue Mar 31 15:09:41 UTC 2009


also sprach Willi Richert <w.richert at gmx.net> [2009.03.31.1656 +0200]:
>     New function: find_k_nearest()
> 
>     Besides:
>     - better checks for memory leaks in swig
>     - cleaned Makefile
>     - better Python tests
>     - fixed C++ test file

Is there any reason you didn't make at least five separate commits?
I find huge, monolithic commits like this, which incorporate
multiple *independent* changes to be very hard to process.

Generally, one commit should have one logical change and be
self-contained, meaning that it the feature must later work. This
includes test code, documentation, etc.

-- 
 .''`.   martin f. krafft <madduck at d.o>      Related projects:
: :'  :  proud Debian developer               http://debiansystem.info
`. `'`   http://people.debian.org/~madduck    http://vcs-pkg.org
  `-  Debian - when you have better things to do than fixing systems
 
"when in doubt, parenthesize. at the very least it will let some
 poor schmuck bounce on the % key in vi."
                                                         -- larry wall
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
Url : http://lists.alioth.debian.org/pipermail/libkdtree-devel/attachments/20090331/82023a8e/attachment.pgp 


More information about the libkdtree-devel mailing list