<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left:1px solid rgb(204, 204, 204);margin:0pt 0pt 0pt 0.8ex;padding-left:1ex">I don't see the benefit of asking the user to include only that<br>
file. I am also not sure about the typedef. That's nicer and<br>
cleaner than a define, but I think that<br>
<br>
#ifndef KDTREE_SIZE_T<br>
#define KDTREE_SIZE_T unsigned int<br>
#endif<br>
<br>
in a header file included by all other header files, is a better way<br>
forward. If the user now needed to override (which we assume is the<br>
exception), s/he'd just<br>
<br>
#define KDTREE_SIZE_T unsigned long long<br>
#include <kdtree++/kdtree.hpp><br>
<br>
If s/he doesn't #define, then the default is used.<br></blockquote><div><br>good suggestion... ok done. <br></div></div><br>Hope you won't be pissed, but I'd like to follow the STL's lead and use size_t as the default. Plus, size_t has been what we've been using in <a href="http://0.6.2." target="_blank">0.6.2.</a><br>
<br>You pointed out that platform differences may make serialization difficult between platforms, but that is the case even for std::vectors...<br><br>Attached are 3 patches, you clone the git repo and then use "git am" to apply each one in turn (Martin already knows this, I didn't)<br>
<br>The next thing to do is fix the bug shown via test_hayne, and I think i've seen another bug in find() where it may return a random (or nearby) point when it can't find the point at all. I'll write a test case for it tomorrow.<br>
<br>If you want to have a look, please go ahead. If people are happy with what i've done, i'll push it to the repository.<br><br>cheers<br>Paul<br><br>