<p>Hi,</p>
<p>I committed Max's patch on the origin/master branch.</p>
<p>Regards,<br>
Sylvain </p>
<p>On 12 Jun 2010 00:12, "Sylvain Bougerel" <<a href="mailto:sylvain.bougerel.devel@gmail.com">sylvain.bougerel.devel@gmail.com</a>> wrote:<br type="attribution">> Thanks for the patch Max. If I can't put it in the code tomorrow, I'll check<br>
> if others can do it.<br>> <br>> On 11 Jun 2010 15:32, "Max Kellermann" <<a href="mailto:max@duempel.org">max@duempel.org</a>> wrote:<br>>> kdtree.hpp does not compile with LLVM's clang++ compiler, because it<br>
>> violates the C++ standard, resulting in the error message:<br>>><br>>> "must qualify identifier to find this declaration in dependent base<br>>> class"<br>>><br>>> This is best explained on the clang home page:<br>
>><br>>> <a href="http://clang.llvm.org/cxx_compatibility.html">http://clang.llvm.org/cxx_compatibility.html</a><br>>><br>>> "When we look up a name used in a class, we usually look into the base<br>
>> classes. However, we can't look into the base class Base<T> because<br>>> its type depends on the template argument T, so the standard says we<br>>> should just ignore it."<br>>> ---<br>
>> kdtree++/kdtree.hpp | 6 +++---<br>>> 1 files changed, 3 insertions(+), 3 deletions(-)<br>>><br>>> diff --git a/kdtree++/kdtree.hpp b/kdtree++/kdtree.hpp<br>>> index 62464a3..706d58d 100644<br>
>> --- a/kdtree++/kdtree.hpp<br>>> +++ b/kdtree++/kdtree.hpp<br>>> @@ -1169,7 +1169,7 @@ namespace KDTree<br>>> {<br>>> typename _Base::NoLeakAlloc noleak(this);<br>>> _Link_type new_node = noleak.get();<br>
>> - _M_construct_node(new_node, __V, __PARENT, __LEFT, __RIGHT);<br>>> + _Base::_M_construct_node(new_node, __V, __PARENT, __LEFT, __RIGHT);<br>>> noleak.disconnect();<br>>> return new_node;<br>>> }<br>
>> @@ -1187,8 +1187,8 @@ namespace KDTree<br>>> void<br>>> _M_delete_node(_Link_type __p)<br>>> {<br>>> - _M_destroy_node(__p);<br>>> - _M_deallocate_node(__p);<br>>> + _Base::_M_destroy_node(__p);<br>
>> + _Base::_M_deallocate_node(__p);<br>>> }<br>>><br>>> _Link_type _M_root;<br>>><br>>><br>>> _______________________________________________<br>>> libkdtree-devel mailing list<br>
>> <a href="mailto:libkdtree-devel@lists.alioth.debian.org">libkdtree-devel@lists.alioth.debian.org</a><br>>> <a href="http://lists.alioth.debian.org/mailman/listinfo/libkdtree-devel">http://lists.alioth.debian.org/mailman/listinfo/libkdtree-devel</a><br>
</p>