[Ltrace-devel] current make check failures
Olaf Hering
olh at suse.de
Thu Sep 14 17:13:15 UTC 2006
On Thu, Sep 14, Olaf Hering wrote:
> On Thu, Sep 14, Olaf Hering wrote:
>
> > The current trunk gives these make check failures in openSuSE 10.2 beta.
>
> On ppc64, everything passes up to r51. make check fails With the change below included
>
> ------------------------------------------------------------------------
> r52 | ianw-guest | 2006-08-07 02:03:15 +0000 (Mon, 07 Aug 2006) | 2 lines
> Changed paths:
> M /ltrace/trunk/ChangeLog
> M /ltrace/trunk/elf.c
>
> refactor to stop warnings
This change changes behaviour:
- ret_val = (GElf_Addr) * (long *)(base + offset);
- return ret_val;
+ return (GElf_Addr)(base + offset);
As I read it, retval was *(base + offset), now its just the sum. This patch fixes it for me:
---
elf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: ltrace-0.4/elf.c
===================================================================
--- ltrace-0.4.orig/elf.c
+++ ltrace-0.4/elf.c
@@ -417,7 +417,7 @@ static GElf_Addr opd2addr(struct ltelf *
if (offset > lte->opd_size)
error(EXIT_FAILURE, 0, "static plt not in .opd");
- return (GElf_Addr)(base + offset);
+ return *(GElf_Addr*)(base + offset);
}
struct library_symbol *read_elf(struct process *proc)
More information about the Ltrace-devel
mailing list