[Ltrace-devel] [PATCH] Fix ppc64 ABI support
Luis Machado
luisgpm at linux.vnet.ibm.com
Wed Feb 27 14:09:56 UTC 2008
On Wed, 2008-02-27 at 14:48 +0100, Olaf Hering wrote:
> On Mon, Feb 25, Luis Machado wrote:
>
> > +++ trunk/sysdeps/linux-gnu/ppc/regs.c 2008-02-25 09:04:49.000000000 -0800
>
> > +void *get_instruction (struct process *proc, void *addr)
> > +{
> > + long data;
> > +
> > + data = ptrace (PTRACE_PEEKTEXT, proc->pid, addr,0);
> > +
> > + if (proc->mask_32bit)
> > + data = (data >> 32) & 0x00000000ffffffff;
> > +
> > + return data;
>
> regs.c:58: warning: return makes pointer from integer without a cast
>
> get_instruction() is currently unused.
Thanks for pointing this out Olaf.
This function slipped through. It can be removed without any impact. Any
other concerns about the overall patch?
Regards,
--
Luis Machado
Software Engineer
IBM Linux Technology Center
More information about the Ltrace-devel
mailing list