[Ltrace-devel] [PATCH] Fix ppc64 ABI support

Anderson Lizardo anderson.lizardo at gmail.com
Wed Feb 27 14:28:38 UTC 2008


Hi Luis,

On Mon, Feb 25, 2008 at 1:40 PM, Luis Machado
<luisgpm at linux.vnet.ibm.com> wrote:
> Hi,
>
>  This is an improvement over the previous patch to fix ppc32 failures in
>  the testsuite.

Your patch seems to not follow coding style of the rest of the code,
mainly that your conditional blocks look like (GNU style ?):

if (something)
  {
       ...;
  }

Whereas the rest of ltrace code uses K&R style:

if (something) {
<tab>...;
}

Also, in a few places you replaced tabs with spaces, which is wrong IMHO.

Besides that, you still use global variables on
sysdeps/linux-gnu/ppc/trace.c for keeping state. AFAIK, this will
cause problems when tracing multiple processes at the same time (e.g.
after a fork() or when passing multiple PIDs using -p option).

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia
Manaus - Brazil



More information about the Ltrace-devel mailing list