[Ltrace-devel] [PATCH 0/6] more minor fixes

[Joe Damato]

On Fri, Dec 10, 2010 at 11:22 AM, Zach Welch <zwelch at codesourcery.com> wrote:
> On 12/10/2010 01:15 AM, Joe Damato wrote:
>> On Wed, Dec 8, 2010 at 6:55 PM, Zachary T Welch <zwelch at codesourcery.com> wrote:
>>> These changes eliminate all remaining warnings (on x86 and ARM) in
>>> order to allow -Werror to be used in all circumstances.  This includes
>>> improving the handling of differences between the libelf and elfutils
>>> declaration of elf_hash() and autotools handling of CFLAGS, CPPFLAGS,
>>> and LDFLAGS.  These patches will apply on top of my recent series
>>> and also deserve to be included in the impending release.
>>
>> I've merged these patches and thanks for this work as well.
>
> There now are other fixes that will need to be applied, since you
> changed a couple of my patches after you applied them. Incidentally,
> modifying another contributor's patches is a bad practice for a
> maintainer; it is better to reject them outright. In the future, please
> respond to the list with the problems that you find rather than silently
> trying to fix them.

oops.

> Presently, I encounter new errors when trying to build your 'master'
> branch; meanwhile, my unmodified patches appear on your 'test' branch,
> and that builds fine (except for the regressions reported in this thread
> that can be fixed using this patch). Fortunately, I can diff the two
> branches and see exactly what you did; it should be fairly easy to fix
> these problems.

hah, we are breaking each other's architectures.

> If you report the problems that you have with the 'test' branch, I will
> make a new patch that addresses the issues that you tried to solve in
> 'master'.

aright i reset master to match test, but it doesnt build on amd64.