[Ltrace-devel] Some patches for ltrace

[Petr Machata]

Andrey Zonov <zont at FreeBSD.org> writes:

> I'm now porting ltrace on FreeBSD amd64 [1] and found a few bugs.
> Please look at the following commits:

Thank you.  Next time around, would you please be so kind as to post
each of those as a patch, like what git-format-patch does?  This would
allow me to review in e-mail, and eventually apply them.

You commit messages start with dashes.  Our don't.  The first line of a
commit message acts similarly to Subject: in e-mail messages.

Apart from the particular commits that you point out.  Most of the
FreeBSD code is very similar to Linux code.  This is guaranteed to
bitrot.  Either FreeBSD will see fixes that would be useful for Linux,
or the other way around.  It seems like the job control parts should be
fairly similar among these two OS's, and it should be possible to reuse
this and only call back to OS hooks for the low-level work.

Also note that I intended to merge pmachata/abi branch for some time
now.  I don't think it collides with your work, but it does touch a lot
of ltrace core, and might introduce bugs that you will see on FreeBSD as
well.  I'll try to get around to the merge really soon now.

> a2d199eda1f0e6dd5e3dc38fdef9383dca602993

I don't understand the problem.  When does it break and how?  Leaking
memory is certainly less bad than crashing, but we would prefer fixing
the underlying bug.

> 22a1b7e90b2a0727ff08fc7224e9a897541ad3cd
> 82a518c836af43592e8f3d3d830902a6500f8f80
> ebd3e4c7e68065f1829ca84d7830c583efc12cff

Why is this needed?

> 9efa0a117c5f00e47ae1f0b6f64a3d7b561cd9b8
> ee55fecf97ebd7a9ec481a9629389eacf69be3d3
> 3558a13d3b8b43fd0e977128bc7b6a75ae3537a0
> 6a1eb194f36d008e5d254447645e06be7baf53ff
>
> [1] https://github.com/z0nt/ltrace

Thank you,
PM