[Ltrace-devel] [PATCH] Add tests for %p format specifier crash and zero(EXPR) leaks

Petr Machata pmachata at redhat.com
Thu Sep 26 21:46:20 UTC 2013


Peter Wu <lekensteyn at gmail.com> writes:

> - The %p test should run when ltrace is built with -fsanitize=address or
>   some other form of protection that makes the program abort when trying
>   to free() static memory.
> - The zero(EXPR) test needs valgrind to test for the previous memleak
>   bug, but as it stands now, it can also test whether the zero
>   functionality works or not.

Both test cases trigger when valgrind is turned on, and both are fixed
by your patches.

> I have never used dejagnu or expect before and these tests were created by
> looking at the above tests. Hopefully they fit well, it looks sane to
> me.

Yeah, looks good.  I put it in.

Thanks,
PM



More information about the Ltrace-devel mailing list