[Ltrace-devel] [PATCH] Add support for using elfutils as unwinder.

[Mark Wielaard]

On Wed, 2014-01-08 at 17:11 +0100, Petr Machata wrote:
> Mark Wielaard <mjw at redhat.com> writes:
> > +AC_CHECK_LIB([dw], [dwfl_getthread_frames], [have_libdw_dwfl_frames=yes])
> > +  AC_SUBST(libdw_LIBS)
> > +  AC_DEFINE([HAVE_LIBDW], [1], [we have elfutils libdw])
> > +  LDFLAGS="${saved_LDFLAGS}"
> 
> This is all unconditional and leads to build errors on systems without
> suitable elfutils.

Oops, sorry. That was a left over copy/paste bug :{
The AC_SUBST and AC_DEFINE should not be there. They are done completely
at the end under the final if test x"$enable_elfutils" = xyes; check.

Removed those two line, and fixed the indentation of the LDFLAGS line.

Also output.c had a '\n' to much when printing the source line, so the
output didn't exactly match what I posted in my last message:

                         if (src != NULL) {
-                                fprintf(options.output, "\n\t%s", src);
+                                fprintf(options.output, "\t%s", src);

Both issues fixed in the newly attached patch.

Thanks,

Mark
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Add-support-for-using-elfutils-as-unwinder.patch
Type: text/x-patch
Size: 14599 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/ltrace-devel/attachments/20140108/1bf2f90e/attachment.bin>