[Ltrace-devel] [PATCH] xtensa: add xtensa support

Petr Machata pmachata at redhat.com
Fri Jul 4 12:54:53 UTC 2014


This looks good.  I'm ready to merge this code-wise.  But please mention
xtensa support in README and NEWS, and if you care, add yourself to
CREDITS (the list is alphabetical by last name).  Sending these
additions as an additional patch is fine by me, depends on what you
prefer.

Max Filippov <jcmvbkbc at gmail.com> writes:

> +long gimme_arg(enum tof type, struct process *proc, int arg_num)

This interface is fairly limited.  I see[1] that xtensa supports passing
some 64-bit arguments in pairs of registers, that just won't work here.
I think ltrace currently aborts if an attempt is made to call gimme_arg
with a data type that wouldn't fit into long.

ltrace has a new set of interfaces to address the limitations of
gimme_arg.  Those are arch_fetch_* family of callbacks, documented in
fetch.h.  This may all be moot, I'm not familiar with xtensa, so it's up
to you whether you want to write this code.  As stated above, I'm ready
to merge what you have now.

[1] http://wiki.linux-xtensa.org/index.php/ABI_Interface

Thanks,
PM



More information about the Ltrace-devel mailing list