[Ltrace-devel] [PATCH] Support for ppc64le (Little Endian and ABIv2) Add new testsuite/ltrace.main/parameters-str.exp file Handles HFA and irelative support

[Thierry Fauck ( thierry @ linux.vnet.ibm.com )]

Hello,

 

>> For non-ELFv2 host, I'm getting:
>> sysdeps/linux-gnu/ppc/fetch.c:119:1: error: 'get_return_info' defined but not used [-Werror=unused-function]
>> sysdeps/linux-gnu/ppc/fetch.c:392:1: error: 'allocate_hfa' defined but not used [-Werror=unused-function]
Yes, adding #ifdef _CALL_ELF == 2 around these functions
>>> diff --git a/sysdeps/linux-gnu/ppc/plt.c b/sysdeps/linux-gnu/ppc/plt.c
>>> index 332daa8..a16e182 100644
>>> --- a/sysdeps/linux-gnu/ppc/plt.c
>>> +++ b/sysdeps/linux-gnu/ppc/plt.c
>> [...]
>>> @@ -430,7 +448,12 @@ reloc_copy_if_irelative(GElf_Rela *rela, void *data)
>>>  int
>>>  arch_elf_init(struct ltelf *lte, struct library *lib)
>>>  {
>>> +
>>> +	/* Check for ABIv2 in ELF header processor specific flag.  */
>>> +	lte->arch.elfv2_abi = ((lte->ehdr.e_flags & EF_PPC64_ABI) == 2);
>>> +
>> So, I don't think we should turn off detection.  It seems appropriate to
>> me to do something like:
>>
>> +#ifndef EF_PPC64_ABI
>> +# define EF_PPC64_ABI 3
>> +#endif
Shouldn't I had this defintion is arch.h when I am not in case _CALL_ELF==2
so when I want to use it I can bail out if EF_PPC_ABI undefined in

arch_elf_init() when I want to use it.

Thanks

-- 
Thierry Fauck (thierry at linux.vnet.ibm.com)