[Ltrace-devel] [PATCH v2] Tracing PLT-less MIPS binaries

[Sedat Dilek]

On Thu, Feb 5, 2015 at 11:41 PM, Faraz Shahbazker
<faraz.shahbazker at imgtec.com> wrote:
> Hi,
>
> Dropped one variable, replacing pc with lladdr throughout.
>
> I found and fixed 2 other issues while testing:
>
> 1. The check for whether GOT entries are already biased in
> arch_elf_add_plt_entry needed update. There are 3 conditions under which
> the GOT entries will be biased:
> - Non-PIE ELFs obviously have biased GOT entries
> - Pre-linked ELFs, likewise
> - when ltrace attaches to an already running process
>
> To capture the last one, I've added a check for whether proc->pid occurs
> in options.h:opt_p - not sure if there is a simpler way of performing
> this check.
>
> 2. mips_unresolved_data is shallow copied for each cloned symbol. If a
> child detaches whilst a symbol remains in NEED_UNRESOLVE state, then
> we shouldn't free its unresolve_data because the parent/siblings may
> still need it. I've added a ref_count field to the struct to fix this.
> I am not sure how(if at all) PPC tackles this problem.
>

Hi Faraz,

nice to see this making progress.
Is this still against pmachata/mips Git branch?
Does it need some extra patches you posted?
Is this RFC?
Can you send out a patch with git send-email even it is RFC and place
(above) some comments?
This is easier for reviewers.

Thanks!

Regards,
- Sedat -