[PATCH] - Adding timestamps to terminal output

Mark Einon mark.einon at gmail.com
Sat Feb 19 15:48:41 UTC 2011


On 19 February 2011 14:03, Adam Lackorzynski <adam at os.inf.tu-dresden.de> wrote:
> Hi,
>
> On Fri Feb 18, 2011 at 23:44:08 +0000, Mark Einon wrote:
>>    Patchfile is attached.
>>
>
> I applied it and further modified it. I like it more when the timestamp
> always prepends each line. What do you think?
>

I did consider that approach, and it isn't hard to change to use it,
or even make it configurable. I decided against it because:

1. The log files produced are greatly increased in size (especially
for an overnight run).
2. Terminals that have limited width (e.g 80 lines) get wrapped /
truncated lines more often
3. Each line printed would go through the process of formatting the
timestamp, which may cause issues on slower machines - although
thinking about it again, you only have to format the timestamp string
when the time changes, so this can be mitigated.

Mark



More information about the minicom-devel mailing list